Bug 443085 - gvfs entries in Places aren't openable
Summary: gvfs entries in Places aren't openable
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-panel
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Ray Strode [halfline]
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F9Blocker
TreeView+ depends on / blocked
 
Reported: 2008-04-18 15:26 UTC by Bill Nottingham
Modified: 2014-03-17 03:14 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-04-23 17:25:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
a patch (6.94 KB, patch)
2008-04-19 05:17 UTC, Matthias Clasen
no flags Details | Diff
next iteration (4.49 KB, patch)
2008-04-21 04:23 UTC, Matthias Clasen
no flags Details | Diff

Description Bill Nottingham 2008-04-18 15:26:43 UTC
Description of problem:

Attempting to click on them yields:

Could not open location 'archive://file%3A%2F%2F%2Fhome%2Fnotting%2Fboot.iso/'
 The default action does not support this protocol.

Version-Release number of selected component (if applicable):

gvfs-0.2.3-5.fc9.x86_64
nautilus-2.22.2-3.fc9.x86_64
gnome-panel-2.22.1.2-2.fc9.x86_64

Comment 1 Ray Strode [halfline] 2008-04-18 15:32:47 UTC
presuming this is a gvfs problem, although i don't really know.

Comment 2 David Zeuthen 2008-04-18 15:49:01 UTC
This works fine from nautilus and appears to be a valid URI and, FWIW, I can
reproduce this with latest packages. It also happens for gphoto2 uri's; I get
"Could not open location 'gphoto2://[usb:001,066]/'


Back to the panel.

Comment 3 Matthias Clasen 2008-04-19 05:17:41 UTC
Created attachment 302967 [details]
a patch

Comment 4 David Zeuthen 2008-04-19 16:45:58 UTC
Probably needs to handle G_IO_ERROR_FAILED_HANDLED in mount_async_callback() too.

Comment 5 David Zeuthen 2008-04-19 17:08:06 UTC
Matthias, please see comment 4

Comment 6 Matthias Clasen 2008-04-21 04:23:18 UTC
Created attachment 303096 [details]
next iteration

The new patch uses the already existing PanelMountOperation rather than rolling
its own, and also handles G_IO_ERROR_FAILED_HANDLED.

Comment 7 Matthias Clasen 2008-04-21 15:29:34 UTC
I'd appreciate if someone could test this patch with some more exotic mounts.
David ?

Comment 8 David Zeuthen 2008-04-21 16:41:42 UTC
Matthias, if you can build it into koji and then ping me on IRC I'll try it
right away. It shouldn't behave much different with exotic mounts but it's
always good to test stuff. Thanks.

Comment 9 Matthias Clasen 2008-04-22 18:00:54 UTC
http://koji.fedoraproject.org/koji/buildinfo?buildID=46708
has builds which should fix this. Please test.

Comment 10 Bill Nottingham 2008-04-22 18:09:48 UTC
Tested those builds, they work for me with the archive mounter. Feel free to
request a tag.

Comment 11 Martin Jürgens 2008-04-22 18:18:56 UTC
Works for me.


Note You need to log in before you can comment on or make changes to this bug.