Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://mcpierce.dyndns.org/~mcpierce/rubygem-rubyforge.spec SRPM URL: http://mcpierce.dyndns.org/~mcpierce/rubygem-rubyforge-0.4.4-1.fc8.src.rpm Description: A script which automates a limited set of rubyforge operations
Review on -2: Good: - rpmlint checks return: rubygem-rubyforge.src: W: mixed-use-of-spaces-and-tabs (spaces: line 41, tab: line 7) rubygem-rubyforge.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/rubyforge-0.4.4/lib/rubyforge.rb 0644 - package meets naming guidelines - package meets packaging guidelines (generic and Ruby) - license (GPLv2+ or Ruby) OK, text not in package, matches source - spec file legible, in am. english - source matches upstream (a955f92ebbb47953c3333c7f8428d3f168506cc4) - package builds on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Please fix the non-executable-script error in a new SRPM/SPEC and I will approve. You may also want to advise upstream to properly license their code, only one file seems to mention the license, and the text of the license is not included in the Gem. This is not a blocker for Fedora inclusion.
Updated the spec to set the execute bit on the rubyforge.rb script. Spec: http://mcpierce.dyndns.org/~mcpierce/rubygem-rubyforge.spec SRPM: http://mcpierce.dyndns.org/~mcpierce/rubygem-rubyforge-0.4.4-3.fc8.src.rpm
APPROVED.
New Package CVS Request ======================= Package Name: rubygem-rubyforge Short Description: A script which automates a limited set of rubyforge operations Owners: mcpierce Branches: F-8 F-9 InitialCC: none Cvsextras Commits: Yes
cvs done.
This is now properly building against rawhide, F8 and F9.