Spec URL: http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka.spec SRPM URL: http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka-0.1-1.fc9.src.rpm Description: The Nodoka theme for xfwm4. A clean theme featuring soft gradients and Echoey look and feel.
If someone could review this package quickly we might be able to make it into final.
Must items: rpmlint clean name OK specfile OK follow the guidelines OK has approved license OK md5 correct for the temporary source on your page package builds OK no locales OK no shared libs OK owns its dirs OK Problems: URL was not correct so I've uploaded the sources in your stead to speed up the review. (https://fedorahosted.org/releases/n/o/nodoka/xfwm4-theme-nodoka-0.1.tar.gz) missing rm -rf $RPM_BUILD_ROOT in %%install section Once you fix the last issue, I'll approve it.
Oh and I missed the srpm rpmlint output: xfwm4-theme-nodoka.src: E: no-cleaning-of-buildroot %install xfwm4-theme-nodoka.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 30) Please fix the warning as well.
(In reply to comment #2) > URL was not correct so I've uploaded the sources in your stead to speed up the > review. thanks (In reply to comment #3) > Oh and I missed the srpm rpmlint output: > xfwm4-theme-nodoka.src: E: no-cleaning-of-buildroot %install > xfwm4-theme-nodoka.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: > line 30) My bad, I did not rpmlint the package. Both fixed in http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka.spec You want me to do another SRPM?
(In reply to comment #4) > (In reply to comment #2) > > URL was not correct so I've uploaded the sources in your stead to speed up the > > review. > thanks > > (In reply to comment #3) > > Oh and I missed the srpm rpmlint output: > > xfwm4-theme-nodoka.src: E: no-cleaning-of-buildroot %install > > xfwm4-theme-nodoka.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: > > line 30) > > My bad, I did not rpmlint the package. Both fixed in > http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka.spec > You want me to do another SRPM? Nice, that's acceptable. Would be better though, to bump the release number and mention the fixes in the %%changelog (and post new srpm here), but I do not require it. ACCEPTED
(In reply to comment #5) > Would be better though, to bump the release number and > mention the fixes in the %%changelog (and post new srpm here), but I do not > require it. > I usually do this but I found these changes to trivial and did not want to do another mockbuild. New Package CVS Request ======================= Package Name: xfwm4-theme-nodoka Short Description: Nodoka theme for xfwm4 Owners: cwickert Branches: F-7 F-8 F-9 InitialCC: mso Cvsextras Commits: no
Why deny cvsextras commits here? Any reason? cvs done.
(In reply to comment #7) > Why deny cvsextras commits here? Any reason? Other people can fix whatever they want on all my packages, but for the artwork I'd like to be in control, since I'm maintaining it upstream too.
xfwm4-theme-nodoka-0.1-1.fc8 has been submitted as an update for Fedora 8
xfwm4-theme-nodoka-0.1-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
xfwm4-theme-nodoka-0.1-1.fc9 and xfwm4-4.4.2-3.fc9 were successfully tagged into f9-final by notting on Wed, 30 Apr 2008 18:01:29, so they will be available in F9. Closing.
Package Change Request ====================== Package Name: xfwm4-theme-nodoka New Branches: el6 Owners: cwickert mso InitialCC:
Git done (by process-git-requests).