Spec URL: http://fedora.danny.cz/py-openhpi.spec SRPM URL: http://fedora.danny.cz/py-openhpi-1.1-1.fc9.src.rpm Description: An extension module that makes it possible to access HPI api functions and structures from the Python language. It supports everything that is exposed through SaHpi.h, SaHpiAtca.h, SaHpiBladeCenter.h, oHpi.h, and oh_utils.h.
scratch build = http://koji.fedoraproject.org/koji/taskinfo?taskID=577485
+ rpmlint output no output ? package name satisfies the packaging naming guidelines I'm dubious about naming the package 'py-openhpi' even though strictly speaking this doesn't violate any Python guideline. I would rename it python-openhpi instead just for consistency with other Python packages in Fedora. + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm + package successfully builds on at least one architecture i386 n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun n/a does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available - reviewer should build the package in mock (but ok coz built in koji) + the package should build into binary RPMs on all supported architectures - review should test the package functions as described n/a scriptlets should be sane n/a pkgconfig files should go in -devel n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin =============== APPROVED However please consider renaming the package to python-openhpi.
The package name was a question for me too. So I will rename it and when somebody will require the upstream name, it can be easily added as Provides. Thanks for the review.
New Package CVS Request ======================= Package Name: python-openhpi Short Description: Python interface for OpenHPI Owners: sharkcz Branches: F-9 InitialCC: Cvsextras Commits: yes
cvs done.
imported and built in devel
Package Change Request ====================== Package Name: python-openhpi New Branches: EL-5