Red Hat Bugzilla – Bug 443469
Review Request: pytrainer - A tool to log all your sport excursions
Last modified: 2008-09-28 14:38:58 EDT
Spec URL: https://rpm.silfreed.net:8002/index.cgi/raw-file/cdccc785d310/pytrainer/pytrainer.spec SRPM URL: http://www.silfreed.net/download/repo/packages/pytrainer/pytrainer-1.5.0.0.1-2.src.rpm Description: A tool to log all your sport excursions.
So the obvious first problem just from starting to look is that this isn't going to work with rawhide/F9 due to the move to xulrunner and firefox3. Working through other some of the other stuff for review, though * Requires: python will be automatically added, no need to explicitly list it * python-sqlite2 is the same API as the sqlite3 module in the stock python package... I'm actually not even sure why we keep shipping it (bug 446389) * There's no COPYING or LICENSE in the upstream tarball. It would be good to get the upstream to make that more explicit as well as ensuring the GPLv2 vs GPLv2+ * rpmlint only warns about lack of documentation, but there's not really anything in the tarball. You could leave out the blank %doc line from %files Otherwise, at least from a quick review, everything looks good. But the firefox thing might be a bit tricky :-/
Okay, doing some playing today with this in rawhide and I get things to work properly with $ LD_LIBRARY_PATH=/usr/lib/xulrunner-1.9pre/ MOZILLA_FIVE_HOME=/usr/lib/xulrunner-1.9pre/ python ./pytrainer.py And without the patch that's in the package. The license looks like the big thing to get to the bottom of and then we should be able to get this in. And then I can write the plugin to have it use the garmin-sync stuff I just submitted for review to sync all of the data off of a Garmin Edge or Forerunner :-)
Spec URL: https://rpm.silfreed.net:8002/index.cgi/file/beb4427ffcf1/pytrainer/pytrainer.sp SRPM URL: http://www.silfreed.net/download/repo/packages/pytrainer/pytrainer-1.5.0.0.1-3.s %changelog * Thu Jun 19 2008 Douglas E. Warner <silfreed@silfreed.net> 1.5.0.0.1-3 - updating to support xulrunner or firefox - removing empty doc line - added patch to use sqlite3 I've emailed the maintainer about adding a LICENSE or COPYING file; I'll let you know once that's in.
Recently changed my paths around a bit; new Spec URL: https://rpm.silfreed.net:8002/file/beb4427ffcf1/pytrainer/pytrainer.spec
Okay, more comprehensive review: * Needs to own %{_datadir}/pytrainer directory rather than just the contents of the directory * I thought we had removed the need for --vendor from the desktop-file-install, but guidelines still include it so I may be mistaken Otherwise, looks good. Fix up the first one before importing it and then once you get the license clarification, include that as well as having the license file as %doc. But APPROVED
I can't find this software neither on koji nor on bodhi. Did you push it? Do you plan to do it?
I'm still waiting on upstream to get back to me about the license issue. I'll go ahead and request CVS be setup and I'll ping upstream about it again. In the meantime you can try the packages from my repository: http://www.silfreed.net/download/repo/packages/pytrainer/
New Package CVS Request ======================= Package Name: pytrainer Short Description: A tool to log all your sport excursions Owners: silfreed Branches: F-8 F-9 Cvsextras Commits: yes
cvs done.
Upstream has said they'll include the license file soon; I'll get the stuff imported and built and wait to push it to updates until that gets in there officially.
works fine for me! i only wish there would be a possibility to show 2 graphs in one graphic (like speed and heartrate)
pytrainer-1.6.0.5-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
pytrainer-1.6.0.5-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.