Created attachment 303736 [details]
The patch to fix : 5.1 Delete  the field isbless from table group_group_map

derive_groups () is used in the token.cgi, but seems the catalog didn't use
this cgi, so remove it simply.

UserCanBlessGroup() is used in the editusers.cgi and userprefs.cgi which didn't
exist in catalog, so remove it simply.

can_bless() is used in the template file :
"template/en/default/global/useful-links.html.tmpl" :

[% ' | <a href="editusers.cgi">Users</a>'     IF user.groups.editusers ||
user.can_bless %]  

but it is not used in the catalog, so remove it simply.

Best Regards!
Nicho

Hi nicho ,

Patch looks good,, maybe it is a good idea also to remove code that calls the 2
subroutines that you removed from User.pm derive_groups() and can_bless(), as
you mentioned before it is in the following places for your quick reference:

./token.cgi:257:    $user->derive_groups;
./token.cgi:300:            $user->derive_groups;

./template/en/default/global/useful-links.html.tmpl:75:                        
                     || user.can_bless %]

Cheers,
Noura

Created attachment 304097 [details]
Patch improve:

Remove below:
./token.cgi:257:    $user->derive_groups;
./token.cgi:300:	    $user->derive_groups;

./template/en/default/global/useful-links.html.tmpl:75: 		       

		     || user.can_bless %]

Pls review

Nicho

Created attachment 304133 [details]
Patch Improve:

Patch looks good, Thanks Nicho

Noura

Please commit this change to CVS and set the status to MODIFIED.

tested and run good