Bug 443564 - FEAT: Match the new db schema of bz3.0 [#8 TABLE namedqueries]
Summary: FEAT: Match the new db schema of bz3.0 [#8 TABLE namedqueries]
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Hardware Certification Program
Classification: Retired
Component: Hardware Catalog
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: XINSUN
QA Contact: Yu Shao
URL:
Whiteboard:
Depends On:
Blocks: hwcert->BZ3_tracker
TreeView+ depends on / blocked
 
Reported: 2008-04-22 08:32 UTC by XINSUN
Modified: 2008-08-04 17:56 UTC (History)
10 users (show)

Fixed In Version: 3.2rh-20080801.1
Clone Of:
Environment:
Last Closed: 2008-08-04 17:56:35 UTC
Embargoed:


Attachments (Terms of Use)
The patch to fix : 8.1 Delete the field linkinfooter from table namedqueries (961 bytes, patch)
2008-04-25 05:42 UTC, XINSUN
no flags Details | Diff
Patch improve: (2.52 KB, patch)
2008-04-29 10:46 UTC, XINSUN
no flags Details | Diff
Patch Improve: (14.65 KB, patch)
2008-04-29 15:29 UTC, XINSUN
no flags Details | Diff

Description XINSUN 2008-04-22 08:32:59 UTC
8.   Relate to TABLE namedqueries need to change list below:
   8.1 Delete  the field  linkinfooter from table  namedqueries
         Added :        N/A
         Removed:    FIELD  namedqueries.linkinfooter

Comment 1 XINSUN 2008-04-25 05:42:54 UTC
Created attachment 303738 [details]
The patch to fix : 8.1 Delete  the field  linkinfooter from table  namedqueries

The linkinfooter is used in the template file :
"template/en/default/global/useful-links.html.tmpl"
:
=============================================================================
 [% FOREACH q = user.queries %]
	  [% IF q.linkinfooter %]
	    [% " | " IF print_pipe %]
	    <a href="buglist.cgi?cmdtype=runnamed&amp;namedcmd=[% q.name FILTER
url_quote %]"><nobr>[% q.name FILTER html %]</nobr></a>
	    [% print_pipe = 1 %]
	  [% END %]
	[% END %]
====================================================================================


The above template file is not used in the hwcert catalog, So remove the field
linkinfooter from the select sql query. pls refer to the patch.

Best Regards!
Nicho

Comment 2 Noura El hawary 2008-04-28 05:23:17 UTC
patch looks good to me nicho, maybe also here is a good idea to remove the code
refering to linkfooter from the template/en/default/global/useful-links.html.tmpl

Cheers,
Noura

Comment 3 XINSUN 2008-04-29 10:46:56 UTC
Created attachment 304100 [details]
Patch improve:

Remove the code
refering to linkfooter from the
template/en/default/global/useful-links.html.tmpl

Pls review,
Nicho

Comment 4 XINSUN 2008-04-29 15:29:08 UTC
Created attachment 304130 [details]
Patch Improve:

Comment 5 XINSUN 2008-04-29 15:30:48 UTC
Created attachment 304131 [details]
Patch Improve:

Comment 6 Noura El hawary 2008-05-01 02:04:45 UTC
Patch looks good,

Thanks nicho.


Comment 7 Rob Landry 2008-07-17 21:03:32 UTC
Please commit this change to CVS and set the status to MODIFIED.

Comment 8 eric_liu 2008-08-01 11:37:23 UTC
tested and run good 


Note You need to log in before you can comment on or make changes to this bug.