Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 443691

Summary: Valgrind errors in store tests.
Product: Red Hat Enterprise MRG Reporter: Alan Conway <aconway>
Component: qpid-cppAssignee: Kim van der Riet <kim.vdriet>
Status: CLOSED CURRENTRELEASE QA Contact: Kim van der Riet <kim.vdriet>
Severity: urgent Docs Contact:
Priority: urgent    
Version: beta   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Results of make check with valgrind. jrnl tests prevented by jtt failure
none
make check for jrnl subdir with valgrind errors. none

Description Alan Conway 2008-04-22 21:26:32 UTC
Description of problem:

After enabling valgrind for all the store C++ test executables, there are 
valgrind errors that need to be resolved.

All tests pass without valgrind (make check VALGRIND=)

Steps to Reproduce:
On a machine with valgrind installed:
 > make check

Additional info:

The jrnl/ tests are extremely slow (40 minutes) under valgrind. They are
probably re-testing the same code paths reundantly in loops, and can probably be
re-factored to run in a reasonable amount of time under valgrind without losing
any code coverage. 

In particular _ut_enq_map.stress seems like an inappropriate build test, perhaps
should be separated into a stress or performance test suite.

Comment 1 Alan Conway 2008-04-22 21:26:32 UTC
Created attachment 303384 [details]
Results of make check with valgrind. jrnl tests prevented by jtt failure

Comment 2 Alan Conway 2008-04-22 22:01:07 UTC
Created attachment 303388 [details]
make check for jrnl subdir with valgrind errors.

Comment 3 Alan Conway 2008-04-22 22:02:40 UTC
I reduce the loop counter in the stress tests to 10 iterations so the tests run
in a reasonable time now. Looking at the logs there are actually not many
valgrind errors, it should be possible to clean them up in less than a day.

Comment 4 Kim van der Riet 2008-04-29 12:20:51 UTC
Most errors were in the tests themselves (being over-simple in their approach)
but one corner case in the journal itself was uncovered. All fixed.

Comment 5 Mike Bonnet 2008-05-16 15:09:15 UTC
qpidc-0.2.656926-1.el5, qpidd-0.2.656926-1.el5, and rhm-0.2.2058-1.el5 have been pushed to the staging repo for testing