Bug 443741 - Review Request: jna-posix - POSIX APIs for Java
Summary: Review Request: jna-posix - POSIX APIs for Java
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Colin Walters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 417511
TreeView+ depends on / blocked
 
Reported: 2008-04-23 03:54 UTC by Conrad Meyer
Modified: 2008-06-12 20:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-06-12 20:27:00 UTC
Type: ---
Embargoed:
walters: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Conrad Meyer 2008-04-23 03:54:29 UTC
URLs:
Spec: http://konradm.fedorapeople.org/fedora/SPECS/jna-posix.spec
SRPM: http://konradm.fedorapeople.org/fedora/SRPMS/jna-posix-0.5-1.fc8.src.rpm
Description:
Common cross-project/cross-platform POSIX APIs for Java.

Note: this is a dependency of JRuby 1.1.1.
I've built it in Koji (no missing BR's) at http://koji.fedoraproject.org/koji/taskinfo?taskID=577179 .

Comment 1 Colin Walters 2008-04-23 17:54:30 UTC
* Spec looks fine
 - I'd change the rm lib/jna.jar to: rm lib/*.jar to be safe
x rpmlint says: jna-posix.noarch: W: no-documentation, need %doc README.txt
? Why do we have a custom build.xml instead of using mvn-jpp?




Comment 2 Conrad Meyer 2008-04-23 18:21:33 UTC
(In reply to comment #1)
> * Spec looks fine
>  - I'd change the rm lib/jna.jar to: rm lib/*.jar to be safe
Sure.
> x rpmlint says: jna-posix.noarch: W: no-documentation, need %doc README.txt
Oops :).
> ? Why do we have a custom build.xml instead of using mvn-jpp?
From the looks of the pom.xml it required wagon-WebDAV, which isn't a part of 
Fedora's maven-wagon package. I've opened a bug for that a while ago (rhbz# 
442641). I'm also lazy and this custom build.xml works fine.

Comment 3 Conrad Meyer 2008-04-24 04:12:52 UTC
New URLs:
Spec: http://konradm.fedorapeople.org/fedora/SPECS/jna-posix.spec
SRPM: http://konradm.fedorapeople.org/fedora/SRPMS/jna-posix-0.5-2.fc8.src.rpm

Added README.txt and LICENSE.txt to %doc, rm lib/*.jar in %prep, and keep 
custom build.xml for now.

Comment 4 Colin Walters 2008-04-24 13:38:54 UTC
Hmm, ok.  Can you add a comment linking to #442641 above your Source: build.xml
then?

Otherwise looks good, approved.

Comment 5 Conrad Meyer 2008-04-24 14:10:29 UTC
Will do. Can you set fedora_cvs to '+' before I ask for CVS? Thanks!

Comment 6 Conrad Meyer 2008-04-24 18:01:56 UTC
Sorry, I meant fedora_review -- thanks for understanding.

New Package CVS Request
=======================
Package Name: jna-posix
Short Description: POSIX APIs for Java
Owners: konradm,walters
Branches: F-8 EL-5
InitialCC: 
Cvsextras Commits: yes

Comment 7 Jason Tibbitts 2008-04-24 19:22:31 UTC
CVS done.  (I created an F-9 branch as well.)

Comment 8 Conrad Meyer 2008-06-12 20:27:00 UTC
Has this not been closed yet? I think it's been pushed to updates. Closing.


Note You need to log in before you can comment on or make changes to this bug.