Spec URL: http://ausil.us/packages/sugar-journal.spec SRPM URL: http://ausil.us/packages/sugar-journal-79-1.fc9.src.rpm Description: Journal activity for sugar.
Created attachment 303796 [details] updated spec OK, I made a few changes: - Since the locale files aren't in /usr/share/locale, you can't use find_lang to pick up the mo files, you're going to have to manually split them out. This will make the %files section a bit more complex for sugar packages, you might consider making a modified find_lang script that finds these and generates a proper file list (%find_sugar_lang). - I set chmod +x on setup.py (not sure why that gets installed, but whatever) to silence rpmlint - You don't need to double package NEWS, the installer puts it in the activity directory, so just mark it as %%doc.
If that spec looks ok to you, let me know, and I'll finish the review.
Spec looks good to me.
Review ========= Good: - rpmlint checks return: * sugar-journal.noarch: W: non-standard-group Sugar/Activities * sugar-journal.src: W: non-standard-group Sugar/Activities * sugar-journal.src: W: strange-permission sugar-journal-checkout.sh 0775 All safe to ignore. - package meets Sugar naming guidelines - package meets Sugar packaging guidelines - license (GPLv2+) OK, copy of license not in source, matches source code - spec file legible, in am. english - source generated with included script - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED (please make sure the new sugar-toolkit package is tagged and in the repodata before rebuilding)
Package Name: sugar-journal Short Description: Journal Activity for the sugar desktop Owners: ausil Branches: F-9 F-8 InitialCC: Cvsextras Commits: yes
cvs done
Built for F-9
Package Change Request ====================== Package Name: sugar-journal New Branches: OLPC-3
I am denying this request it is unneeded. Tomeu, please ensure that you speak with the package maintainer before requesting branches for OLPC-3