Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 444413

Summary: Cannot use attach disk if subdriver option is wrong in blktap
Product: Red Hat Enterprise Linux 5 Reporter: Adam Stokes <astokes>
Component: xenAssignee: Daniel Berrangé <berrange>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 5.3CC: gozen, sputhenp, tao, xen-maint
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-20 21:12:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 391501, 409971, 449772    
Attachments:
Description Flags
Backport of upstream changeset to RHEL5
none
Backport of upstream changeset to RHEL5 v2 none

Description Adam Stokes 2008-04-28 10:19:33 UTC
Description of problem:
I do the following setting in the disk item of the definition file.

--- /etc/xen/guest_domain ---
name = "guest_domain"
...
disk = [ "phy:/dev/sda5,xvda,w", "tap:ZZZ:/root/file.img,hda,w" ]
vif = [ "mac=00:16:3e:5b:f1:0d,bridge=xenbr0,script=vif-bridge" ]
-----------------------------

Though a definition of disk is wrong,
I can start a domain by a "xm create (virsh start)" command
and disk of the wrong definition is connected on a guest domain.

Version-Release number of selected component (if applicable):
xen 3.0

How reproducible:
100%

Steps to Reproduce:
1. make a image file.
# dd if=/dev/zero of=/root/file.img count=1000 bs=5000000

2. add the following setting to the disk item of the definition file.
"tap:ZZZ:/root/file.img,hda,w"
    ^^^
3. start a guest domain with the definition file which increased a change with
step-2.
xm create /etc/xen/guest_domain
(virsh start guest_domain)

  
Actual Results:
Though a definition is wrong,
VM boots but cannot use tap:ZZZ disk.

Expected Result:
"xm create (virsh start)" output an error.

Additional info:
changeset 15815: 2f13d0f2b07c
 xend: Add blktap disk type check
 http:/ /xenbits.xensource.com/xen-unstable.hg/rev/2f13d0f2b07c

Comment 1 RHEL Program Management 2008-06-02 20:03:38 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 2 Daniel Berrangé 2008-07-09 13:30:25 UTC
Since the patch is upstream, its easy enough to add this

Comment 4 Daniel Berrangé 2008-07-10 12:06:52 UTC
Created attachment 311470 [details]
Backport of upstream changeset to RHEL5

Comment 5 Daniel Berrangé 2008-07-10 12:17:13 UTC
Created attachment 311471 [details]
Backport of upstream changeset to RHEL5 v2

Comment 7 Daniel Berrangé 2008-07-21 10:48:28 UTC
Built into xen-3.0.3-67.el5

Comment 10 errata-xmlrpc 2009-01-20 21:12:49 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0118.html