Bug 444414 - kernel: tehuti: check register size
Summary: kernel: tehuti: check register size
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: CVE-2008-1675
TreeView+ depends on / blocked
 
Reported: 2008-04-28 10:22 UTC by Jan Lieskovsky
Modified: 2008-05-02 10:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-02 10:57:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jan Lieskovsky 2008-04-28 10:22:51 UTC
Description of problem:

Alan Cox has reported the following issue:

<cite>

Random auditing results

tehuti has no security checks on the do_ioctl functions and
it has ioctl methods for patch arbitary 32bit offset from
registers with arbitary 32bit value. Nasty hole

</cite>

Version-Release number of selected component (if applicable):
From 2.6.24

  
Actual results:


Expected results:


Additional info:

The Tehuti network driver first appeared in 2.6.24 version of the Linux
kernel:

http://www.linuxhq.com/kernel/v2.6/24/drivers/net/tehuti.h

Proposed upstream patch:

http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=6131a2601f42cd7fdbac0e960713396fe68af59f

Comment 2 Jan Lieskovsky 2008-04-28 10:32:36 UTC
Please have a look also at BZ#444416 to see how to move ioctl perm check closer
to function start in the Tehuti driver.

Comment 3 Chuck Ebbert 2008-05-01 06:37:43 UTC
Patch in 2.6.25-13


Note You need to log in before you can comment on or make changes to this bug.