Bug 444601 - Review Request: pem - Pem is personal expenses manager
Review Request: pem - Pem is personal expenses manager
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Christoph Wickert
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-04-29 10:35 EDT by kushaldas@gmail.com
Modified: 2008-07-23 02:56 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-07-23 02:23:09 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
cwickert: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description kushaldas@gmail.com 2008-04-29 10:35:42 EDT
Spec URL: http://kushal.fedorapeople.org/pem.spec
SRPM URL: http://kushal.fedorapeople.org/pem-0.7.1-1.fc9.src.rpm
Description: Pem, is personal expenses manager. Pem lets keep track of
personal income and expense in an extremely elegant manner
Comment 1 Christoph Wickert 2008-04-29 14:30:05 EDT
Kushal, I would be happy to review this package.
Comment 2 kushaldas@gmail.com 2008-04-29 15:27:30 EDT
thank you :)
Comment 3 Christoph Wickert 2008-04-29 17:07:44 EDT
cd9524c18ca7a86b1063b4b9f2b5c7d1  pem-0.7.1-1.fc9.src.rpm

OK - MUST: no output from rpmlint
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package
OK - MUST: package meets the Packaging Guidelines
FAIL - SHOULD: %description should end with a dot
OK - MUST: licensed with a Fedora approved license (GPLv2 only)
OK - MUST: license field in the spec file matches the actual license
OK - MUST: package includes a copy of the license text which is correctly
installed in %doc
OK - MUST: spec file is written in American English
OK - MUST: spec file is legible
OK - MUST: source matches upstream
FAIL - MUST: source URL is wrong. Source0 should be
http://pjp.dgplug.org/tools/%{name}-%{version}.tar.gz and URL
OK - MUST: package successfully compiles and builds into binary rpms on x86_64.
OK - MUST: no ExcludeArch since this package is noarch
OK - MUST: all build requirements are listed in BuildRequires 
OK - MUST: no locales to care about
OK - MUST: no shared lib to care about
OK - MUST: not relocatable
OK - MUST: no directories to own
OK - MUST: no duplicate files in the %files listing
OK - MUST: permissions on files are set properly
OK - MUST: package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
OK - MUST: package uses macros consistently
OK - MUST: package contains code not content
OK - MUST: no large docs
OK - MUST: docs don't affect runtime
OK - MUST: no header files for a devel package
OK - MUST: no static libs
OK - MUST: no libtool archives
OK - MUST: no GUI, so no %{name}.desktop needed
OK - MUST: packages doesn't own files or directories already owned by other packages
OK - MUST: BuildRoot is properly prepared at the beginning of %install
OK - MUST: all filenames are valid UTF-8
OK - SHOULD: builds in mock
OK - SHOULD: functions as described
OK - SHOULD: Texinfo scriptlets are sane (taken from the wiki)

APPROVED, if you fix the errors. As they are trivial you can do this after the
cvs import but you NEED TO FIX them before build.
Comment 4 kushaldas@gmail.com 2008-04-30 03:25:16 EDT
thanks , errors fixed :)

Spec URL: http://kushal.fedorapeople.org/pem.spec
SRPM URL: http://kushal.fedorapeople.org/pem-0.7.1-2.fc9.src.rpm

Comment 5 kushaldas@gmail.com 2008-04-30 03:39:02 EDT
New Package CVS Request
Package Name: pem
Short Description: Pem is personal expenses manager
Owners: kushal
Branches: F-8 F-9 EL-5 OLPC-2
InitialCC: kushal
Cvsextras Commits: yes
Comment 6 kushaldas@gmail.com 2008-04-30 03:49:00 EDT
New Package CVS Request
Package Name: pem
Short Description: Personal Expenses Manager
Owners: kushal
Branches: F-8 F-9 EL-5
InitialCC: kushal
Cvsextras Commits: yes

I made some mistake in the previous request , this is the correct one.
Comment 7 Kevin Fenzi 2008-04-30 13:02:25 EDT
cvs done.
Comment 8 Christoph Wickert 2008-04-30 17:48:38 EDT
Kushal, if you use the spec from comment #4 there still is a typo in the
  "Pem, is personal expenses manager."
should be
  "Pem is a personal expenses manager."
Comment 9 Christoph Wickert 2008-05-26 05:59:43 EDT
Kushal, can this review be closed?
Comment 10 kushaldas@gmail.com 2008-06-16 15:40:43 EDT
Sorry for the delay.
Rawhide build failed, other F9,F8,EPEL were successful

Comment 11 pjp 2008-06-17 03:46:18 EDT
> Rawhide build failed, other F9,F8,EPEL were successful

  Hey, please check out the latest release of Pem-0.7.2

at: http://pjp.dgplug.org/tools/pem-0.7.2.tar.gz

I've fixed the info dir entry problem. Please let me know in case of any other

Thank you!
Comment 12 kushaldas@gmail.com 2008-07-02 04:48:14 EDT
again rawhide failed due to same problem 
Comment 13 pjp 2008-07-02 06:28:55 EDT
  Hello Kushal, you need to add this

 rm -f $RPM_BUILD_ROOT/%{_infodir}/dir

to the pem.spec under %install, after make install.
Comment 14 kushaldas@gmail.com 2008-07-02 07:21:48 EDT
My point is this is coming only in rawhide not in other branches ?
Comment 15 pjp 2008-07-02 07:29:29 EDT
I don't know, it should not happen like that. Anyway that `rm' command is necessary.
Comment 16 Mamoru TASAKA 2008-07-02 09:01:36 EDT
(In reply to comment #14)
> My point is this is coming only in rawhide not in other branches ?

Well, actually not exact. Even on dist-f9-updates-candidate
build fails:

You can reproduce this by:
$ PATH=/sbin:$PATH rpmbuild --rebuild pem-0.7.2-1.fc10.src.rpm
The point is to add "PATH=/sbin:$PATH". Actually on mockbuild, rpmbuild is executed
as mockbuild user but PATH is set as which root has.
Then you can find this part on Makefile.in:
   680          @if (install-info --version && \
   681               install-info --version 2>&1 | sed 1q | grep -i -v debian)
>/dev/null 2>&1; then \
   682            list='$(INFO_DEPS)'; \
   683            for file in $$list; do \
   684              relfile=`echo "$$file" | sed 's|^.*/||'`; \
   685              echo " install-info --info-dir='$(DESTDIR)$(infodir)'
   686              install-info --info-dir="$(DESTDIR)$(infodir)"
"$(DESTDIR)$(infodir)/$$relfile" || :;\
   687            done; \
   688          else : ; fi
This behavior (i.e. if install-info is found in PATH, install-info is executed
on install) is common for info files.
Comment 17 pjp 2008-07-10 04:46:13 EDT
Kushal: ping, did you build it again?
Comment 18 Mamoru TASAKA 2008-07-21 02:40:05 EDT
Kushal, ping?
Comment 19 kushaldas@gmail.com 2008-07-22 07:02:14 EDT
Build successfully on devel.
I messed up in F-9 branch with tagging. Will try to fix and fresh build once the
outage is over.
Comment 20 Fedora Update System 2008-07-23 02:31:32 EDT
pem-0.7.2-3.fc9 has been submitted as an update for Fedora 9
Comment 21 Fedora Update System 2008-07-23 02:56:25 EDT
pem-0.7.2-3.fc8 has been submitted as an update for Fedora 8

Note You need to log in before you can comment on or make changes to this bug.