Spec URL: http://kushal.fedorapeople.org/pem.spec SRPM URL: http://kushal.fedorapeople.org/pem-0.7.1-1.fc9.src.rpm Description: Pem, is personal expenses manager. Pem lets keep track of personal income and expense in an extremely elegant manner
Kushal, I would be happy to review this package.
thank you :)
REVIEW for cd9524c18ca7a86b1063b4b9f2b5c7d1 pem-0.7.1-1.fc9.src.rpm OK - MUST: no output from rpmlint OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package OK - MUST: package meets the Packaging Guidelines FAIL - SHOULD: %description should end with a dot OK - MUST: licensed with a Fedora approved license (GPLv2 only) OK - MUST: license field in the spec file matches the actual license OK - MUST: package includes a copy of the license text which is correctly installed in %doc OK - MUST: spec file is written in American English OK - MUST: spec file is legible OK - MUST: source matches upstream FAIL - MUST: source URL is wrong. Source0 should be http://pjp.dgplug.org/tools/%{name}-%{version}.tar.gz and URL http://pjp.dgplug.org/tools/ OK - MUST: package successfully compiles and builds into binary rpms on x86_64. OK - MUST: no ExcludeArch since this package is noarch OK - MUST: all build requirements are listed in BuildRequires OK - MUST: no locales to care about OK - MUST: no shared lib to care about OK - MUST: not relocatable OK - MUST: no directories to own OK - MUST: no duplicate files in the %files listing OK - MUST: permissions on files are set properly OK - MUST: package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT OK - MUST: package uses macros consistently OK - MUST: package contains code not content OK - MUST: no large docs OK - MUST: docs don't affect runtime OK - MUST: no header files for a devel package OK - MUST: no static libs OK - MUST: no libtool archives OK - MUST: no GUI, so no %{name}.desktop needed OK - MUST: packages doesn't own files or directories already owned by other packages OK - MUST: BuildRoot is properly prepared at the beginning of %install OK - MUST: all filenames are valid UTF-8 OK - SHOULD: builds in mock OK - SHOULD: functions as described OK - SHOULD: Texinfo scriptlets are sane (taken from the wiki) APPROVED, if you fix the errors. As they are trivial you can do this after the cvs import but you NEED TO FIX them before build.
thanks , errors fixed :) Spec URL: http://kushal.fedorapeople.org/pem.spec SRPM URL: http://kushal.fedorapeople.org/pem-0.7.1-2.fc9.src.rpm
New Package CVS Request ======================= Package Name: pem Short Description: Pem is personal expenses manager Owners: kushal Branches: F-8 F-9 EL-5 OLPC-2 InitialCC: kushal Cvsextras Commits: yes
New Package CVS Request ======================= Package Name: pem Short Description: Personal Expenses Manager Owners: kushal Branches: F-8 F-9 EL-5 InitialCC: kushal Cvsextras Commits: yes I made some mistake in the previous request , this is the correct one.
cvs done.
Kushal, if you use the spec from comment #4 there still is a typo in the description: "Pem, is personal expenses manager." should be "Pem is a personal expenses manager."
Kushal, can this review be closed?
Sorry for the delay. Rawhide build failed, other F9,F8,EPEL were successful http://koji.fedoraproject.org/koji/taskinfo?taskID=664148
> Rawhide build failed, other F9,F8,EPEL were successful Hey, please check out the latest release of Pem-0.7.2 at: http://pjp.dgplug.org/tools/pem-0.7.2.tar.gz I've fixed the info dir entry problem. Please let me know in case of any other issues. Thank you!
again rawhide failed due to same problem http://koji.fedoraproject.org/koji/getfile?taskID=691682&name=build.log
Hello Kushal, you need to add this rm -f $RPM_BUILD_ROOT/%{_infodir}/dir to the pem.spec under %install, after make install.
My point is this is coming only in rawhide not in other branches ?
I don't know, it should not happen like that. Anyway that `rm' command is necessary.
(In reply to comment #14) > My point is this is coming only in rawhide not in other branches ? Well, actually not exact. Even on dist-f9-updates-candidate build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=692056 You can reproduce this by: $ PATH=/sbin:$PATH rpmbuild --rebuild pem-0.7.2-1.fc10.src.rpm The point is to add "PATH=/sbin:$PATH". Actually on mockbuild, rpmbuild is executed as mockbuild user but PATH is set as which root has. Then you can find this part on Makefile.in: ---------------------------------------------------------------------------------- 680 @if (install-info --version && \ 681 install-info --version 2>&1 | sed 1q | grep -i -v debian) >/dev/null 2>&1; then \ 682 list='$(INFO_DEPS)'; \ 683 for file in $$list; do \ 684 relfile=`echo "$$file" | sed 's|^.*/||'`; \ 685 echo " install-info --info-dir='$(DESTDIR)$(infodir)' '$(DESTDIR)$(infodir)/$$relfile'";\ 686 install-info --info-dir="$(DESTDIR)$(infodir)" "$(DESTDIR)$(infodir)/$$relfile" || :;\ 687 done; \ 688 else : ; fi ---------------------------------------------------------------------------------- This behavior (i.e. if install-info is found in PATH, install-info is executed on install) is common for info files.
Kushal: ping, did you build it again?
Kushal, ping?
Build successfully on devel. I messed up in F-9 branch with tagging. Will try to fix and fresh build once the outage is over.
pem-0.7.2-3.fc9 has been submitted as an update for Fedora 9
pem-0.7.2-3.fc8 has been submitted as an update for Fedora 8