Spec URL: http://pfj.fedorapeople.org/gtksourceview2-sharp.spec SRPM URL: http://pfj.fedorapeople.org/gtksourceview2-sharp-1.0-1.fc9.src.rpm Description: gtksourceview2-sharp is a set of binding to enable C# users to use gtksourceview2
I think you should include the "number" somewhere into version or release. It looks like Subversion or other version control revision number to me.
True - however %{number}-1 may cause problems further up the chain if this is version control system...
Okay I promised I would take this, here goes a first glance: If it is a svn snapshot then the strongly prefered way to deal with this is labelling the package as such. An example of the syntax can be seen here: http://cvs.fedoraproject.org/viewcvs/rpms/WebKit/devel/WebKit.spec?view=markup Mono specs need the following line: ExclusiveArch: %ix86 x86_64 ppc ia64 armv4l sparc alpha Can you explain what the rm -rf % line is intended to accomplice? Aside that rpmlint is silent and the spec is readable (though I would like comments as always when you do sed magic to explain what you do, it makes it easier for co-maintainers and people who care for your packages while you are on vacation/sick to follow along). Does not build in mock (fedora-devel-x86_64), needs to br gtk-sharp2-devel instead of gtk-sharp-devel.
Paul?
Um - updated version already up! pfj.fedorapeople.org/gtksourceview2-sharp-1.0-2.svn89788.fc9.src.rpm
Just so we are absolutely clear, Paul you need to update the bug report so the reviewer can see you made updates, it is not my responsibility to hit your fedorapeople space periodically to see if you made updates. APPROVED
Thanks - I did email back to BZ when your comments were returned. Dunno what happened...
New Package CVS Request ======================= Package Name: gtksourceview2-sharp Short Description: mono bindings for gtksourceview2 Owners: pfj Branches: f8, f9 InitialCC: pfj Cvsextras Commits: yes
cvs done.