$ rpmlint phplogcon-2.1.3-1.noarch.rpm
phplogcon.noarch: 
W:symlink-should-be-relative /usr/share/phplogcon/config.php /etc/phplogcon/config.php
How can I fix it?

phplogcon.noarch: E: zero-length /etc/phplogcon/config.php
It's empty config file, what's the problem?

phplogcon.noarch: E: non-standard-gid /etc/phplogcon apache
phplogcon.noarch: E: non-standard-gid /etc/phplogcon/config.php apache
I have Requires: httpd"

> W:symlink-should-be-relative /usr/share/phplogcon/config.php
/etc/phplogcon/config.php
> How can I fix it?

ln -s             %{_sysconfdir}/%{name}/config.php
%{buildroot}/%{_datadir}/%{name}/config.php
 => 
ln -s             ../../../%{_sysconfdir}/%{name}/config.php
%{buildroot}/%{_datadir}/%{name}/config.php 
 
> phplogcon.noarch: E: zero-length /etc/phplogcon/config.php
> It's empty config file, what's the problem?

Why is a empty file needed? Put a comment or something there or remove it.


> phplogcon.noarch: E: non-standard-gid /etc/phplogcon apache
> phplogcon.noarch: E: non-standard-gid /etc/phplogcon/config.php apache
> I have Requires: httpd"

Could be ignored.

However 
Require: webserver 
is more correct than 
Require: httpd ?

You are not using dist tags?

Put a README.fedora in %doc to explain how to do the initial setup?


 

Spec URL: http://people.redhat.com/pvrabec/rpms/phplogcon.spec
SRPM URL: http://people.redhat.com/pvrabec/rpms/phplogcon-2.3.1-1.fc7.src.rpm

thnx. for suggestions. 

I think there isn't README.fedora in tarball. I can create some howto with 
upstream later.

A few changes will be needed:

1. rpmlint barfs
rpmlint -v /home/users/tmraz/src/rpm/SRPMS/phplogcon-2.3.1-1.fc9.src.rpm
phplogcon.src: I: checking
phplogcon.src: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line 30)

2. As the phplogcon is not configured when the rpm is installed I suggest to
modify the apache config file so the http://<whatever>/phplogcon/ is not
accessible by default at all.

3. If the install.php is removed as suggested by it when it is run, it will be
readded when the phplogcon rpm is upgraded. So the sources should be patched to
make install.php just being ignored when phplogcon is already configured.

4. The README.fedora should be created with notes about how it could/should be
set up also there might be some notes that it preferably should be used with
mysql as the source of the logs because of permissions and selinux issues when
/var/log/.... files are used.

3.

Is this

%post
if [ "$1" -eq "2" ]; then
        rm -rf %{_datadir}/%{name}/install.php
fi

phplogcon.noarch: W: dangerous-command-in-%post rm

acceptable?

Not really because it could still be there unconfigured in the time of the
upgrade. And also it would always mean that rpm -V would barf that the
install.php is missing.

http://people.redhat.com/pvrabec/rpms/phplogcon.spec
http://people.redhat.com/pvrabec/rpms/phplogcon-2.3.1-1.fc7.src.rpm

All points from comment #4 are fixed. install.php is not removed anymore. If 
it's empty, it will be considered as not configured.

README.fedora is provided.

The link to package should be probably:
http://people.redhat.com/pvrabec/rpms/phplogcon-2.1.6-1.beta.fc7.src.rpm

I'd prefer the phplogcon.conf http config file to be in a separate file in the
src.rpm and not in the spec. I'd also prefer if it contained:

Alias /phplogcon /usr/share/phplogcon/

<Directory /usr/share/phplogcon>
    Order Deny,Allow
    Deny from All
    ErrorDocument 403 "Access denied per /etc/httpd/conf.d/phplogcon.conf."
</Directory>

This way not even the 127.0.0.1 is enabled by default and the administrator
knows which file should be fixed to get the access.

Also the README.fedora still contains instructions to rename/move the
install.php which is not necessary anymore.

There is also a typo s/change #setenfore=0/run 'setenforce 0' to switch to
permissive mode/ s/to #setenfore=1/with 'setenforce 1'/

Also adjust it with regards to my comment #9.

here we go:
http://people.redhat.com/pvrabec/rpms/phplogcon-2.1.6-1.beta.fc7.src.rpm

All the recommendations were applied, except the restricting phplogcon from
localhost. I considered it too restrictive in comparison with security hazard.

You mean http://people.redhat.com/pvrabec/rpms/phplogcon-2.1.6-2.beta.fc7.src.rpm
don't you?

Created attachment 306480 [details]
Fixed Fedora README

I still did not like the changes in README.fedora, so I have attached a fixed
one for you.

The license is GPLv3+ as I see it in the source files and not GPLv3 (version 3
only).

Why are you copying the config sample into /etc/ and then removing it? Please
fix also this.

This and comment 13 and 14 should be the last changes needed.

http://people.redhat.com/pvrabec/rpms/phplogcon-2.1.6-3.beta.fc7.src.rpm

All problems seem to be resolved now.

rpmlint -v phplogcon-2.1.6-3.beta.fc9.src.rpm
phplogcon.src: I: checking

rpmlint -v phplogcon-2.1.6-3.beta.fc9.noarch.rpm
phplogcon.noarch: I: checking
phplogcon.noarch: E: non-standard-gid /etc/phplogcon/config.php apache
phplogcon.noarch: E: zero-length /etc/phplogcon/config.php
phplogcon.noarch: E: non-standard-gid /etc/phplogcon apache

This is OK as httpd is a required package.

The package is now approved.

New Package CVS Request
=======================
Package Name: phplogcon
Short Description: A syslog data viewer for the web
Owners: pvrabec
Branches: F-9
InitialCC:
Cvsextras Commits: yes

cvs done.