Bug 444730 - kdm crashes after upgrade to F-9 due to missing theme
Summary: kdm crashes after upgrade to F-9 due to missing theme
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kdebase-workspace
Version: rawhide
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F9Target
TreeView+ depends on / blocked
 
Reported: 2008-04-30 11:23 UTC by Dean Mander
Modified: 2008-05-10 12:16 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-10 12:09:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 161480 0 None None None Never

Description Dean Mander 2008-04-30 11:23:51 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b5) Gecko/2008042509 Fedora/3.0-0.55.beta5.fc9 Firefox/3.0b5

Description of problem:
error when kdm starts after upgrade to F-9 preview:

"Cannot parse theme file /usr/share/apps/kdm/themes/FedoraInfinity"
then it exits and I'm dropped to VT1.

After setting an existing theme in /etc/kde/kdm/kdmrc, the problem is gone.


Version-Release number of selected component (if applicable):
kdebase-workspace-4.0.3-18.fc9.x86_64 (kdm)

How reproducible:
Always


Steps to Reproduce:
1. upgrade from F-8 (kde 3.5 with Fedora Infinity Theme)
2. to F-9 preview
3. with DISPLAYMANAGER="KDE" in /etc/sysconfig/desktop



Actual Results:


Expected Results:
I would expect, if the theme disappears during upgrade, that it is automatically replaced by a/the new one.

Secondly, KDM should use "no" or the "default" team rather than stopping and halting X.

When switching to GDM, there is a similar error warning on the missing theme, but gdm keeps on running with the "default" theme.



Additional info:

Comment 1 Rex Dieter 2008-04-30 11:27:57 UTC
Old themes simply aren't compatible.  The new default theme is FedoraWaves.

> Secondly, KDM should use "no" or the "default" team rather than stopping and
halting X.

I agree, please report that upstream to bugs.kde.org.

Comment 2 Dean Mander 2008-05-01 08:49:33 UTC
> Old themes simply aren't compatible.  The new default theme is FedoraWaves.
If so, why isn't the incompatible theme changed during my offline upgrade?
Without, it just breaks the system.

I mean, that kind of stuff is exactly the excuse why Fedora promotes offline
rather than live upgrades, so the installer can notify and fix stuff that breaks
because of the upgrade.

Comment 3 Dean Mander 2008-05-01 09:09:51 UTC
> I agree, please report that upstream to bugs.kde.org.
for the second problem: http://bugs.kde.org/show_bug.cgi?id=161480


Comment 4 Rex Dieter 2008-05-01 11:27:35 UTC
Reopening.

Early on in the dev-cycle, I hit that "can't open Theme" error, but it at least
didn't crash X.  I'll try to confirm that.

Comment 5 Rex Dieter 2008-05-01 11:29:52 UTC
Ick, ok, confirmed, will continue to track upstream.

Comment 6 Rex Dieter 2008-05-01 11:32:10 UTC
ok, sorry for the bz spam, reopening, I've got some possible ideas here, mostly
involving %post hacks to check for valid/existing themes.

Comment 7 Kevin Kofler 2008-05-01 11:37:44 UTC
Something like "If Theme in 
{Bluecurve,FedoraDNA,FedoraFlyingHigh,FedoraInfinity} change Theme to 
FedoraWaves" should work.

Comment 8 Kevin Kofler 2008-05-01 11:41:17 UTC
In sed, that would be:
sed -i -e 's!^Theme=/usr/share/apps/kdm/themes/(Bluecurve|FedoraDNA|
FedoraFlyingHigh|
FedoraInfinity)$!Theme=/usr/share/kde4/apps/kdm/themes/FedoraWaves!g' /etc/kde/kdm/kdmrc
or a catch-all to replace all KDM 3 themes:
sed -i -e 's!^Theme=/usr/share/apps/kdm/themes/.*$!Theme=/usr/share/kde4/apps/kdm/themes/FedoraWaves!g' /etc/kde/kdm/kdmrc
(please test before committing ;-) ).

Comment 9 Rex Dieter 2008-05-01 14:02:19 UTC
A version of hack from comment #8 is going in kde-settings-4.0-22

Comment 10 Rex Dieter 2008-05-01 14:17:41 UTC
fixed build available, please test:
http://koji.fedoraproject.org/koji/buildinfo?buildID=47798

Comment 11 Dean Mander 2008-05-01 20:20:22 UTC
Tested but failed.

The %{_kde4_datadir} variable in the specfile must be incorrect,
because it replaces

/usr/share/apps/kdm/themes/FedoraInfinity
with
/usr/share/apps/kdm/themes/FedoraWaves

while the actual theme is located in:
/usr/share/kde4/apps/kdm/themes/FedoraWaves



Comment 12 Rex Dieter 2008-05-01 20:35:51 UTC
Hmm... it worked here.  I'll have to retest and doublecheck.

Comment 13 Kevin Kofler 2008-05-01 20:43:11 UTC
You used %{_kde4_datadir}/apps instead of %{_kde4_appsdir} (which 
is %{_kde4_datadir}/kde4/apps).

Comment 14 Kevin Kofler 2008-05-01 21:04:00 UTC
Should be fixed in kde-settings-4.0-22.fc9.1:
http://koji.fedoraproject.org/koji/buildinfo?buildID=47829

Comment 15 Dean Mander 2008-05-01 22:27:30 UTC
Confirmed. This fixes the problem.
Great work!


Note You need to log in before you can comment on or make changes to this bug.