Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Lingua-Preferred.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Lingua-Preferred-0.2.4-1.fc9.kwizart.src.rpm Description: Perl extension to choose a language
From your spec: %files %defattr(-,root,root,-) %doc Changes %dir %{perl_vendorlib}/Lingua/ %{perl_vendorlib}/Lingua/Preferred.pm %{perl_vendorlib}/auto/Lingua/ %dir %{perl_vendorlib}/auto/Lingua %{perl_vendorlib}/auto/Lingua/Preferred/autosplit.ix %{_mandir}/man3/*.3* Why are you doing this so complicated, where %{perl_vendorlib}/Lingua %{perl_vendorlib}/auto/Lingua %{_mandir}/man3/*.3* would suffice? The way you are doing it is error prone (check %{perl_vendorlib}/auto/Lingua in your spec, it's broken)
yep I have a file listed twice. Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Lingua-Preferred.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Lingua-Preferred-0.2.4-2.fc8.kwizart.src.rpm Description: Perl extension to choose a language
README file is missing in %doc
Well OK - Can I add it before import - Or anyone see another problem ?
I am experiencing a strange issue with this package's URL in CPAN: http://search.cpan.org/dist/Lingua-Preferred/ returns "The distribution 'Lingua-Preferred' cannot be found, did you mean one of these" list of 236 other module follows ... Going to http://search.cpan.org/~edavis/ and clicking on "Lingua::Preferred" returns "No matches" So ... there is something weird going on with this package's records in CPAN.
I have emailed CPAN with the hope that this module can be correctly referenced. At time time, this package is recommended (but optional) by xmltv. (not acceptable in fedora since it can collect data from websites and thus conflict with the EULA of them).
It doesn't look like the CPAN issues are fixed, but I don't think that should prevent approval of this package. It can still be downloaded so the only thing missing is the URL; I'd say just comment it out and add an explanatory comment to the spec. This will elicit a "no-url-tag" complaint from rpmlint but I don't see a better alternative; having an incorrect URL tag seems worse. The Summary: is a bit content-free. CPAN seems to use "Pick a language based on user's preferences" which seems better to me. Honestly both of these are trivial fixes; you can make them when you check in. * source files match upstream: fa58c4fac6b676f78caad6b472a785dd0c8fa67004a62294fbcfa3a3eb243c83 Lingua-Preferred-0.2.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. ? summary is kind of lame. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Lingua::Preferred) = 0.2.4 perl-Lingua-Preferred = 0.2.4-2.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(AutoLoader) perl(Exporter) perl(strict) perl(vars) * %check is present and all tests pass. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED
Thx for the review, I will update the Summary, but i didn't get what to with the URL. If I stay as it is, maybe it can get fixed later. But if I comment the URL, this suggest the problem in is the spec (missing URL field) whereas the problem seems releated to CPAN... This is my point of view. But I will follow advices. I have email cpan admin, but without answer yet. I will resent a mail to the owner of the module.
New Package CVS Request ======================= Package Name: perl-Lingua-Preferred Short Description: Pick a language based on user's preferences Owners: kwizart Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes
cvs done.