Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Lingua-EN-Numbers-Ordinate.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Lingua-EN-Numbers-Ordinate-1.02-1.fc8.kwizart.src.rpm Description: Perl functions for giving the ordinal form of a number given its cardinal value
+ source files match upstream : e92078fafd9108a137972c4e9bae9e99 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + %clean is present. + package builds in mock. + package installs properly + rpmlint is silent + final provides and requires are sane + %check is present and all tests pass + owns the directories it creates - doesn't own any directories it shouldn't. The directories below are installed and owned : /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Lingua /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Lingua/EN /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Lingua/EN/Numbers /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Lingua/EN/Numbers/Ordinate + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package.
maybe one of the requires is not correct : perl >= 1:5 Adding this in %prep removes it: sed -i -e '/require 5;/d' lib/Lingua/EN/Numbers/Ordinate.pm
I will add this ^^ and fix directory ownership with %{perl_vendorarch}/auto/* %{perl_vendorlib}/Lingua/ But what I don't understand is that rpmbuild doesn't fail if I omit the %{perl_vendorarch}/auto/* Which makes me wonder, do theses files are really needed for a noarch package ? /usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux-thread-multi/auto/Lingua ? I think there is a problem with our perl packaging guideline here (probably for noarch).
http://kwizart.fedorapeople.org/SPECS/perl-Lingua-EN-Numbers-Ordinate.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Lingua-EN-Numbers-Ordinate-1.02-2.fc8.kwizart.src.rpm Description: Perl functions for giving the ordinal form of a number given its cardinal value
looks good, APPROVED.
New Package CVS Request ======================= Package Name: perl-Lingua-EN-Numbers-Ordinate Short Description: Perl functions for giving the ordinal form of a number given its cardinal value Owners: kwizart Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes
cvs done.