Bug 444776 - iBFT target info not parsed properly by the iscsi_ibft module
Summary: iBFT target info not parsed properly by the iscsi_ibft module
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.3
Hardware: All
OS: Linux
Target Milestone: rc
: ---
Assignee: Mike Christie
QA Contact: Martin Jenner
Depends On:
Blocks: KernelPrio5.3
TreeView+ depends on / blocked
Reported: 2008-04-30 15:06 UTC by Shyam kumar Iyer
Modified: 2018-10-20 01:02 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-01-20 20:00:31 UTC

Attachments (Terms of Use)
Config details. (1.04 KB, text/plain)
2008-04-30 15:08 UTC, Shyam kumar Iyer
no flags Details
Patch to correct eot_offset calculation problem (553 bytes, patch)
2008-06-10 14:59 UTC, Shyam kumar Iyer
no flags Details | Diff
Patch Signed-off-by: Shyam Kumar Iyer <shyam_iyer@dell.com> (608 bytes, patch)
2008-08-18 09:16 UTC, Shyam kumar Iyer
no flags Details | Diff

System ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:0225 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.3 kernel security and bug fix update 2009-01-20 16:06:24 UTC

Description Shyam kumar Iyer 2008-04-30 15:06:54 UTC
Description of problem:
iBFT info is not parsed properly by the iscsi_ibft module and hence the sysfs 
does not export the target information to the /sys/firmware/ibft directories.
The result of this is that the installer will not be able to connect to the 
iSCSI target automatically.

Version-Release number of selected component (if applicable):
RHEL-5.2-Snapshot-6., Kernel-2.6.18-90.el5
Patch that introduced this bug -

How reproducible:

Steps to Reproduce:
1.Configure the NIC firmware to populate iBFT region with iSCSI target 
information to connect to.
2.Start install of RHEL-5.2-Snapshot6.
3. Hint: Use the target iqn name given in the attachment config detail i.e. 
Actual results:
1. The installer does not connect automatically to the target.

Expected results:
1. The installer should connect automatically to the target.

Additional info:
This is is a regression caused by the linux-2.6-firmware-ibft_iscsi-prevent-
misconfigured-ibfts.patch which does not calculate the eot_offset value 
correctly and hence the kobject is not created properly for the target to be 
exported via sysfs.

Comment 1 Shyam kumar Iyer 2008-04-30 15:08:47 UTC
Created attachment 304241 [details]
Config details.

Comment 2 Shyam kumar Iyer 2008-04-30 15:21:37 UTC
Oops. I forgot to go the issue-tracker way. Pardon me for jumping to bugzilla 
here. Creating issue-tracker for this.

Comment 3 Shyam kumar Iyer 2008-04-30 15:27:19 UTC
Issue tracker id 177822 created for this issue.

Comment 5 Mike Christie 2008-06-04 21:15:37 UTC
Does Dell have a patch by any chance.

Comment 6 Mike Christie 2008-06-04 21:17:05 UTC
(In reply to comment #5)
> Does Dell have a patch by any chance.

Do we also have a Dell box for this? Does dell have the iscsi firmware on their
box or is this on a intel or broadcom card? If it is on a nic then we probably
do not need a dell box to replicate and test it here.

Comment 7 Shyam kumar Iyer 2008-06-10 14:56:53 UTC
The issue does not require a Dell box. It just requires a particular iqn name 
The issue is because of an offset calculatation error in the iscsi_ibft.c 
code.  Due to this error directory structure for the target 
in /sys/firmware/ibft does not get created and so the initiator is unable to 
connect to the target.

Note that this bug surfaced only with an name that had a short section at the 
eg: "iqn.1984-05.com.dell:dell".
It did not surface when the iqn's had a longer section at the end.
eg: "iqn.2001-04.com.example:storage.disk2.sys1.xyz"

So, the eot_offset was calculated such that an extra 48 bytes i.e. the size of 
the ibft_header which has already been accounted was subtracted twice.

This was not evident with longer iqn names because they would overshoot the 
total ibft length more than 48 bytes and thus would escape the bug.

Attaching the patch that fixes the issue.
I think upstream needs this fix as well.

Comment 8 Shyam kumar Iyer 2008-06-10 14:59:09 UTC
Created attachment 308821 [details]
Patch to correct eot_offset calculation problem

Patch to correct eot_offset calculation problem.

Comment 9 Mike Christie 2008-06-10 20:50:38 UTC
Thanks for the explanation and patch! Adding devel ack for 5.3.

Comment 11 Shyam kumar Iyer 2008-08-18 09:16:49 UTC
Created attachment 314468 [details]
Patch Signed-off-by: Shyam Kumar Iyer <shyam_iyer@dell.com>

Comment 12 Don Zickus 2008-09-10 20:13:43 UTC
in kernel-2.6.18-110.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 13 Shyam kumar Iyer 2008-09-11 11:27:45 UTC
Tested with the test kernel specified in comment#12.

iSCSI boot happened sucessfully with different iqn names including -

iqn.1984-05.com.dell:dell which used to cause the kernel panic earlier.

Comment 17 Chris Ward 2008-11-14 14:03:27 UTC
~~~ Attention Partners! ~~~

Please test this URGENT / HIGH priority bug at your earliest convenience to ensure it makes it into the upcoming RHEL 5.3 release. The fix should be present in the Partner Snapshot #2 (kernel*-122), available NOW at ftp://partners.redhat.com. As we are approaching the end of the RHEL 5.3 test cycle, it is critical that you report back testing results as soon as possible. 

If you have VERIFIED the fix, please add PartnerVerified to the Bugzilla Keywords field to indicate this. If you find that this issue has not been properly fixed, set the bug status to ASSIGNED with a comment describing the issues you encountered.

All NEW issues encountered (not part of this bug fix) should have a new bug created with the proper keywords and flags set to trigger a review for their inclusion in the upcoming RHEL 5.3 or other future release. Post a link in this bugzilla pointing to the new issue to ensure it is not overlooked.

For any additional questions, speak with your Partner Manager.

Comment 18 Chris Ward 2008-11-18 18:12:05 UTC
~~ Snapshot 3 is now available ~~ 

Snapshot 3 is now available for Partner Testing, which should contain a fix that resolves this bug. ISO's available as usual at ftp://partners.redhat.com. Your testing feedback is vital! Please let us know if you encounter any NEW issues (file a new bug) or if you have VERIFIED the fix is present and functioning as expected (add PartnerVerified Keyword).

Ping your Partner Manager with any additional questions. Thanks!

Comment 19 Chris Ward 2008-11-28 06:44:04 UTC
~~ Attention ~~ Snapshot 4 is now available for testing @ partners.redhat.com ~~

Partners, it is vital that we get your testing feedback on this important bug fix / feature request. If you are unable to test, please clearly indicate this in a comment to this bug or directly with your partner manager. If we do not receive your test feedback, this bug is at risk from being dropped from the release.

If you have VERIFIED the fix, please add PartnerVerified to the Bugzilla Keywords field, along with a description of the test results. 

If you encounter a new bug, CLONE this bug and request from your Partner manager to review. We are no longer excepting new bugs into the release, bar critical regressions.

Comment 20 Shyam kumar Iyer 2008-12-02 07:39:06 UTC
This issue has been verified to be fixed. The patch is also present. Testing was done with snapshot3 and snapshot4.

Comment 23 errata-xmlrpc 2009-01-20 20:00:31 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.