Spec URL: http://mtasaka.fedorapeople.org/Review_request/cairo-dock/cairo-dock.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/cairo-dock/cairo-dock-1.5.5.3-1.date20080501.tmp.src.rpm Description: An light eye-candy fully themable animated dock for any Linux desktop. It has a family-likeness with OSX dock, but with more options. Koji scratch build: for dist-f9-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=592195 for dist-f8-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=592194 rpmlint: ---------------------------------------------------------- cairo-dock-devel.i386: W: no-documentation cairo-dock-plug-ins.i386: W: no-documentation cairo-dock-plug-ins.i386: E: script-without-shebang /usr/lib/cairo-dock/plug-in/netspeed/netspeed cairo-dock-plug-ins-xfce.i386: W: no-documentation cairo-dock-themes.i386: W: no-documentation ---------------------------------------------------------- IMO all of these are ignorable.
http://mtasaka.fedorapeople.org/Review_request/cairo-dock/cairo-dock-1.5.5.4-1.date20080506.tmp.src.rpm http://mtasaka.fedorapeople.org/Review_request/cairo-dock/cairo-dock.spec * Fri May 9 2008 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 1.5.5.4-1.date20080506 - 1.5.5.4 koji scratch build: For dist-f9-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=601391 For dist-f8-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=601396
http://mtasaka.fedorapeople.org/Review_request/cairo-dock/cairo-dock-1.5.5.4-2.date20080506.tmp.src.rpm http://mtasaka.fedorapeople.org/Review_request/cairo-dock/cairo-dock.spec * Sun May 11 2008 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 1.5.5.4-2.date20080506 - Remove mail plug-in for now as there is license conflict - Enable weblet plug-in koji scratch build: For dist-f9-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=603625 For dist-f8-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=603626
For dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=610634
*** Bug 446664 has been marked as a duplicate of this bug. ***
Full review done, summary: Approved! Long story, my thats one not so pretty package. I don't say I could do it better though, its just that what upstream delivers is a big mess. I strongly urge you to contact upstream and to ask them to clean things up, fix the issues which make you now require todo an autoreconf, maybe release atleast the -themes package in a seperate tarbal, stop the ugly version and date in tarbal name stuff, etc.
Yes, I will contact with upstream because actually there are lots of things which must be cleaned up (including license issue of mail/ plugin...) Thanks for your review! New Package CVS Request ======================= Package Name: cairo-dock Short Description: Light eye-candy fully themable animated dock Owners: mtasaka Branches: F-9 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Finally it built on devel, F-9, F-8, closing. Thank you for the review and cvs procedure!
You have got the version wrong cairo-dock-1.5.5.4-5.svn990_trunk.fc10 It should be 1.5.5.6 ( the full title is 1.5.5.6-alpha1 )
I don't see 1.5.5.6 is released.
(In reply to comment #10) > I don't see 1.5.5.6 is released. Ok we both got the version wrong ( it's a fast moving target ) If you are build svn builds you are building the development version i.e 1.5.6-beta2 Try looking in about in the cairo-dock meneu as this will give it's true version or from commandline [root@localhost leigh]# cairo-dock --version 1.5.6-beta2 [root@localhost leigh]#
(In reply to comment #11) > Ok we both got the version wrong ( it's a fast moving target ) > If you are build svn builds you are building the development version i.e 1.5.6-beta2 I already know from which file this version comes (actually cairo-dock/configure.ac). However - Upstream seems to be saying that all 1.5.5.x version is pre-releases for 1.5.6, i.e. development version toward 1.5.6 - In configure.ac, actually version was set as 1.5.5.3 -> 1.5.6-XXX >-> 1.5.5.4 -> 1.5.6-beta2. So it is highly possible that upstream releases 1.5.5.5 or so. - Also "1.5.6 beta2" is ambiguous as several svn trunk seems to have been tagged as beta2 So using 1.5.6 as version is very dangerous as it may cause to introduce epoch. Also for versioning please refer to http://fedoraproject.org/wiki/Packaging/NamingGuidelines
So what are you going to name it then ? If it was me , I would probably name it cairo-dock-1.5.5.9.svn990.fc10
(In reply to comment #13) > So what are you going to name it then ? > If it was me , I would probably name it > > cairo-dock-1.5.5.9.svn990.fc10 This will cause a problem when upstream releases 1.5.5.5
Package Change Request ====================== Package Name: cairo-dock New Branches: F-10 Owners: mtasaka Early branching request.
cvs done