Red Hat Bugzilla – Bug 445086
viewing update detail unbound local error yumbackend
Last modified: 2008-05-06 13:11:44 EDT
Description of problem:
During use of the view updates dialog, an error was produced
Version-Release number of selected component (if applicable):
Reproduced with the python-sqlalchemy package listed.
Steps to Reproduce:
1. update icon says one update pending
2. click, show updates
The dialog expands, and opens up the lower part for description, and then
disappears, showing error dialog:
An internal system error has occurred
A problem that we were not expecting has occurred. Please report this bug with
the error description.
Error Type: <type 'exception.UnboundLocalError'>
line 1325, in _get_update_extras
href = ref['href']
details of that package update.
This has worked for other updates.
Created attachment 304449 [details]
This looks like a real problem from a quick look at the code -- if there aren't
references, then ref is never getting set before its used
This bug was caused by improper tab->space conversion. This problem does not
exist in the yum2 backend.
Created attachment 304472 [details]
An untested patch that may fix the problem.
You lost the 'if refs' check -- which may or may not matter. Otherwise, it
looks sane from not knowing the code ;)
Yeah, the refs check shouldn't matter -- the
yum.update_md.UpdateNotice.references defaults to an empty list.
Robin, Richard, can we get this fix built ?
Ok, so apparently the refs check *is* necessary. Attaching a tested patch that
seems to do the trick.
Created attachment 304527 [details]
A tested patch that fixes this issue
Fixed in 34368f7fa13b3ac7d2a16d570d450a027e66dd75
Need a build in dist-f9-updates-candidate and mail to email@example.com
with the nvr for tagging please :)
Is this okay to mark as a release blocker? Cheers for fixing this guys. I'll do
a snapshot release tmw morning and get this into F9.
Tagged for the tree.