Bug 445338 - Review Request: gstreamer-plugins-flumpegdemux - MPEG demuxer for GStreamer
Review Request: gstreamer-plugins-flumpegdemux - MPEG demuxer for GStreamer
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Clasen
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-05-06 05:46 EDT by Bastien Nocera
Modified: 2008-05-07 08:15 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-05-06 19:30:13 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mclasen: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Bastien Nocera 2008-05-06 05:46:59 EDT
Spec URL: http://www.gnome.org/~hadess/gst-fluendo-mpegdemux/gstreamer-plugins-mpegdemux.spec
SRPM URL: http://www.gnome.org/~hadess/gst-fluendo-mpegdemux/gstreamer-plugins-flumpegdemux-0.10.15-1.fc8.src.rpm
Description: This package contains an MPEG demuxer for the GStreamer multimedia framework.
It allows to separate audio and video in MPEG streams, so that they can be
Comment 1 Bastien Nocera 2008-05-06 05:48:07 EDT
FYI, I'll fix the spec file naming before uploading.
Comment 2 Bastien Nocera 2008-05-06 05:49:08 EDT
Original review request:
Comment 3 Hans de Goede 2008-05-06 09:38:11 EDT
I can confirm that this is fine legal wise, I just got the following from Spot:
"Looks fine, demuxing is ok, just not encode/decode."
Comment 4 Matthias Clasen 2008-05-06 11:24:36 EDT
Builds ok in mock

rpmlint output:

gstreamer-plugins-flumpegdemux.i386: E: zero-length
gstreamer-plugins-flumpegdemux.i386: W: invalid-license MPL 1.1
gstreamer-plugins-flumpegdemux.i386: W: no-url-tag

...and its right ! Those should be fixed.
Comment 5 Matthias Clasen 2008-05-06 11:42:00 EDT
Formal review:

package name: ok, considering we've done the gst -> gstreamer expansion
   consistently for all gstreamer packages in the distro
spec file name: ok
packaging guidelines: just add the url tag and you are fine
license: ok
license field: the official tag is MPLv1.1 I think, it should be used
licence file: ok
spec language: ok
spec legibility: excellent
upstream sources: ok
builds: yes
excludearch: n/a
build deps: ok
locale handling: ok
ldconfig: ok
relocatable: n/a
directory ownership: ok, since it requires gstreamer
%files: ok
file permissions: ok
%clean: ok
content: permissible
large docs: ok
headers: ok
static libs: ok
pc files: ok
shared libs: ok
devel package: n/a
la files: ok
gui app: n/a
file ownership: ok
%install: ok

- fix license tag
- add url tag

Comment 7 Matthias Clasen 2008-05-06 12:01:01 EDT
Looks fine now. Approved
Comment 8 Bastien Nocera 2008-05-06 14:10:05 EDT
New Package CVS Request
Package Name: gstreamer-plugins-flumpegdemux
Short Description: MPEG demuxer for GStreamer
Owners: hadess
Branches: F-9 devel
Cvsextras Commits: yes
Comment 9 Kevin Fenzi 2008-05-06 16:59:14 EDT
cvs done.
Comment 10 Bastien Nocera 2008-05-06 19:30:13 EDT
Built in rawhide and F-9.
Comment 11 Rodd Clarkson 2008-05-06 20:17:43 EDT
Right I installed this package and still no luck.

A little more research showed that at some stage totem-xine had been installed
(I didn't do it, or at least not intentionally) and that totem was trying to use
the xine backend.

I removed this package and all is good now.

I still can't view the menu's on DVD.  I thought totem shoudl now do this. 
Should I file a bug report?

Comment 12 Bastien Nocera 2008-05-07 08:15:56 EDT
(In reply to comment #11)
> I still can't view the menu's on DVD.  I thought totem shoudl now do this. 
> Should I file a bug report?

No, it doesn't do menus. It just gives you all the tracks listed in the playlist.

Note You need to log in before you can comment on or make changes to this bug.