Bug 445347 - Review Request: python-shout - python binding for libshout
Summary: Review Request: python-shout - python binding for libshout
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-05-06 12:00 UTC by Xavier Lamien
Modified: 2008-06-02 10:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-02 10:23:34 UTC
Type: ---
bdpepple: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Xavier Lamien 2008-05-06 12:00:31 UTC
Spec URL: http://laxathom.fedorapeople.org/RPMS/python-shout/python-shout.spec
SRPM URL: http://laxathom.fedorapeople.org/RPMS/python-shout/python-shout-0.2-1.fc8.src.rpm

Description:

python-shout allows you to act as a source for icecast 1 and 2, and
shoutcast. This module includes inline documentation, or see
the included example.py for a demonstration of its usage.

Comment 1 Brian Pepple 2008-05-27 19:32:22 UTC
MD5Sum:
80bec97a1462c2d2a9282ba8a7c18336  shout-python-0.2.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Files have appropriate permissions and owners
* Rpmlint does not find problems
* Package installs and uninstalls cleanly

Minor:
* Looking at the header of shout.c, it looks like the license tag should be
LGPLv2+, not LGPLv2.

+1 APPROVED.

Comment 2 Xavier Lamien 2008-05-28 15:44:51 UTC
Thanks Brian.


CVS Branch Request :
=======================
Package Name: python-shout
Description: python binding for libshout
Initial Owners: laxathom
Branches: F-8 F-9 EL-5




Comment 3 Kevin Fenzi 2008-05-30 19:49:09 UTC
cvs done.

Comment 4 Xavier Lamien 2008-06-02 10:23:34 UTC
Thanks Kevin.

Imported and built.


Note You need to log in before you can comment on or make changes to this bug.