Bug 445447 - fedora-cvs crashes on missing cert file, can't be used by unconfirmed-contributors
Summary: fedora-cvs crashes on missing cert file, can't be used by unconfirmed-contrib...
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-packager
Version: 10
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2008-05-06 20:52 UTC by Kyle VanderBeek
Modified: 2009-01-09 22:55 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-01-09 06:28:40 UTC
Type: ---

Attachments (Terms of Use)
Replacement fedora-cvs.py, cleaned up and made more useful (2.06 KB, text/x-python)
2008-05-06 20:52 UTC, Kyle VanderBeek
no flags Details

Description Kyle VanderBeek 2008-05-06 20:52:29 UTC
Description of problem:
An exception is thrown when ~/.fedora.cert can't be found/read.  Additionally,
this utility can't be used if you don't yet have ssh commit access (such as with
a part-time contributor).

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Move ~/.fedora.cert out of the way.
2. fedora-cvs Pyrex
3. Stack trace is generated.
Actual results:
!!!    cannot read your ~/.fedora.cert file   !!!
!!! Ensure the file is readable and try again !!!
Traceback (most recent call last):
  File "/usr/bin/fedora-cvs", line 48, in <module>
  File "/usr/bin/fedora-cvs", line 37, in main
    userName = readUser()
  File "/usr/bin/fedora-cvs", line 16, in readUser
AttributeError: 'module' object has no attribute 'exit'

Expected results:
!!!    cannot read your ~/.fedora.cert file   !!!
!!! Ensure the file is readable and try again !!!

(with no stack trace).

Additional info:
The simple patch is to fix the minor bug and call sys.exit(1) instead of the
non-existant os.exit(1).  However, in the interest of clean code, I'm attaching
a replacement fedora-cvs.py which is PEP-8 clean, adds command line
parsing/help, and allows anonymous checkouts for people that don't have
ssh/commit access but still want to help with packaging efforts.

Comment 1 Kyle VanderBeek 2008-05-06 20:52:29 UTC
Created attachment 304688 [details]
Replacement fedora-cvs.py, cleaned up and made more useful

Comment 2 Bug Zapper 2008-11-26 10:39:26 UTC
This message is a reminder that Fedora 8 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 8.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '8'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 8's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 8 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 

Comment 3 Bug Zapper 2009-01-09 06:28:40 UTC
Fedora 8 changed to end-of-life (EOL) status on 2009-01-07. Fedora 8 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.