Bug 445642 - add ia64 support for livecd-tools
Summary: add ia64 support for livecd-tools
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: livecd-tools
Version: 9
Hardware: ia64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jeremy Katz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-ia64
TreeView+ depends on / blocked
 
Reported: 2008-05-08 09:04 UTC by Zhan, Yi
Modified: 2008-10-15 16:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-15 16:02:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
add ia64 support for livecd-tools (5.12 KB, patch)
2008-05-08 09:04 UTC, Zhan, Yi
no flags Details | Diff

Description Zhan, Yi 2008-05-08 09:04:19 UTC
Description of problem:

Hi, 

I have written a patch for livecd-tools to add ia64 support. The generated image
has been tested on several ia64 boxes. Everything worked fine (haven't test
installing from it yet). The patch is attached. 

Since I am not very familiar with livecd project. What I have done is just
writing a ia64LiveImageCreator subclass for ia64, as x86 does. Then implement
necessary functions. Please review the patch to see if anything is missing or
inappropriate. I'm happy to try things out if you have no easy access to ia64
boxes. 

Thanks, 
Yi

Version-Release number of selected component (if applicable):
livecd-tools-017-1.fc9

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Zhan, Yi 2008-05-08 09:04:19 UTC
Created attachment 304845 [details]
add ia64 support for livecd-tools

Comment 2 Bug Zapper 2008-05-14 10:49:21 UTC
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Jeremy Katz 2008-05-14 14:43:48 UTC
It's a lot easier to do patch reviews and handling on the list
(fedora-livecd-list) rather than via bugzilla, especially for something substantial.

Just from a quick look, the patch needs at least some work to really be apply-able
* Rather than overriding the __get_kernel_versions() method, it'd be better to
just make the main method more flexible to work with both the ia64 and not case
* The copy_background stuff seems superfluous since it never gets used
* Your copying and bootloader config generation don't support multiple kernels
which is something that we generally support

Nothing else really jumped out at me but others on the list might notice something

Comment 5 Jeremy Katz 2008-10-15 16:02:22 UTC
Closing due to inactivity and lack of patch submission to fedora-livecd-list


Note You need to log in before you can comment on or make changes to this bug.