Bug 445863 - linux-2.6.9-MOXA-buffer-overflow-in-moxa-driver.patch typo
linux-2.6.9-MOXA-buffer-overflow-in-moxa-driver.patch typo
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel (Show other bugs)
All Linux
low Severity low
: rc
: ---
Assigned To: Ivan Vecera
Martin Jenner
Depends On:
  Show dependency treegraph
Reported: 2008-05-09 10:39 EDT by Johnny Hughes
Modified: 2008-09-04 12:06 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-09-04 12:06:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Johnny Hughes 2008-05-09 10:39:24 EDT
Description of problem:
there is a typo in linux-2.6.9-MOXA-buffer-overflow-in-moxa-driver.patch in the
just released kernel (2.6.9-67.0.15.EL) on line 15.  it says:

+       if(dltmp.cardno < 0 || dltmp.cardno >= MAX_BOARDS || dltmp.len < 0 ||
dltmp.len > sizeof(moxaBuf))

it should be:

+       if(dltmp.cardno < 0 || dltmp.cardno >= MAX_BOARDS || dltmp.len < 0 ||
dltmp.len > sizeof(moxaBuff))

(the last "f" is missing in moxaBuff)

This typo causes moxa.c to not compile if it is enabled and a new kernel compiled.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1.  Enable MOXA serial card in the kernel config file and recompile the kernel.

Actual results:
Kernel compile fails with this error:

drivers/char/moxa.c: In function `MoxaDriverIoctl':
drivers/char/moxa.c:1687: error: `moxaBuf' undeclared (first use in this function)
drivers/char/moxa.c:1687: error: (Each undeclared identifier is reported only once
drivers/char/moxa.c:1687: error: for each function it appears in.)

Expected results:
Kernel should build.
Comment 1 Prarit Bhargava 2008-05-12 08:48:23 EDT
While we (Red Hat) do not ship the moxa module, it should at least compile.

Comment 2 Ivan Vecera 2008-09-04 12:04:02 EDT
The moxa driver is no longer shipped in the RHEL-4 kernel and the affected patch was reverted.

Note You need to log in before you can comment on or make changes to this bug.