Bug 445915 - Review Request: flute - Java CSS parser using SAC
Summary: Review Request: flute - Java CSS parser using SAC
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-05-09 20:03 UTC by Caolan McNamara
Modified: 2008-07-23 17:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-07-23 17:58:54 UTC
Type: ---
Embargoed:
lkundrak: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Caolan McNamara 2008-05-09 20:03:40 UTC 
Spec URL: http://people.redhat.com/caolanm/jfreereport/flute.spec
SRPM URL: http://people.redhat.com/caolanm/jfreereport/flute-1.3-3jpp.1.fc9.src.rpm
Description: Java CSS parser using SAC
Comment 1 Jason Tibbitts 2008-06-27 21:26:04 UTC 
Crap, I happened to not notice the jpp thing in the release before I took this
package, and I was trying to avoid reviewing any packages that used it.  So I'll
return this to the queue.
Comment 2 Lubomir Rintel 2008-07-23 12:52:25 UTC 
Thanks for the package!

Please remove the jpp tag. Revision: 4%{?dist} will be just fine I guess.
Also, the %description sucks, you can probably turn it into something more
descriptive.

The package seems fine in other respects, rpmlint is happy, so is the QA script
and so am I. I'll approve it once the mock build finishes for me.
Comment 3 Lubomir Rintel 2008-07-23 13:38:22 UTC 
Okay, built in mock. rpmlint passes for resulting rpms, nothing strange in
build.log. Dependencies seem sane.

APPROVED

And please address the issue with Release: and %description mentioned in the
comment above this before you commit. Thanks!
Comment 4 Caolan McNamara 2008-07-23 13:56:23 UTC 
New Package CVS Request
=======================
Package Name: flute
Short Description: Java CSS parser
Owners: caolanm
Branches: 
InitialCC:
Cvsextras Commits: yes
Comment 5 Kevin Fenzi 2008-07-23 15:59:21 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.