Bug 446415 - Review Request: GLC_lib - C++ class library for OpenGL application based on Qt 4
Summary: Review Request: GLC_lib - C++ class library for OpenGL application based on Qt 4
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ed Hill
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 446417
TreeView+ depends on / blocked
 
Reported: 2008-05-14 15:11 UTC by Nicolas Chauvet (kwizart)
Modified: 2008-05-18 11:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-05-18 11:52:21 UTC
Type: ---
Embargoed:
ed: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Nicolas Chauvet (kwizart) 2008-05-14 15:11:42 UTC 
Spec URL:
http://kwizart.fedorapeople.org/SPECS/GLC_lib.spec
SRPM URL: 
http://rpms.kwizart.net/fedora/9/SRPMS/GLC_lib-0.9.8-1.fc9.kwizart.src.rpm
Description: C++ class library for OpenGL application based on Qt 4
Comment 1 Ed Hill 2008-05-17 14:55:42 UTC 
Hi kwizart,

This package seems to be in good shape:

 + source matches upstream sha1sum:
fc893ad72f6d0e5da240c2ae963510fb34edeb82  GLC_lib_src_0_9_8.zip_UPSTREAM
fc893ad72f6d0e5da240c2ae963510fb34edeb82  GLC_lib_src_0_9_8.zip
 + license is correct and correctly included
 + proper use of ldconfig
 + clean section and "rm -rf $RPM_BUILD_ROOT" in install
 + specfile is simple, clean, and macros look OK
 + builds in mock (F8 x86_64)
 + rpmlint reports two warnings which can be safely ignored:
GLC_lib.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/GLC_lib-0.9.8/COPYING
GLC_lib-devel.x86_64: W: no-documentation
 + dir ownership looks good

so its APPROVED.

I'll review the GLC_Player (bug # 446417) next.
Comment 2 Nicolas Chauvet (kwizart) 2008-05-17 15:22:56 UTC 
Thx for the review! 
I will fix the file encoding anyway. (thx for notice).
Comment 3 Nicolas Chauvet (kwizart) 2008-05-17 15:25:19 UTC 
New Package CVS Request
=======================
Package Name: GLC_lib
Short Description: C++ class library for OpenGL application based on Qt 4
Owners: kwizart
Branches: F-8 F-9 EL-4 EL-5
Cvsextras Commits: yes
Comment 4 Kevin Fenzi 2008-05-17 20:40:47 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.