Bug 446639 - Review Request: gupnp - GUPnP is an framework for creating UPnP devices & control points
Summary: Review Request: gupnp - GUPnP is an framework for creating UPnP devices & con...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
Depends On: 446637
Blocks: 447456 447457 454664 454668
TreeView+ depends on / blocked
Reported: 2008-05-15 14:21 UTC by Peter Robinson
Modified: 2008-08-13 18:24 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-08-13 18:24:55 UTC
Type: ---
rjones: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Peter Robinson 2008-05-15 14:21:05 UTC
Spec URL: http://fedora.roving-it.com/rawhide/gupnp.spec
SRPM URL: http://fedora.roving-it.com/rawhide/gupnp-0.10-1.fc9.src.rpm
Description: GUPnP is an object-oriented open source framework for creating UPnP
devices and control points, written in C using GObject and libsoup.
The GUPnP API is intended to be easy to use, efficient and flexible.

Comment 1 Peter Robinson 2008-05-19 22:35:28 UTC
Updated to the latest release

Spec URL: http://fedora.roving-it.com/rawhide/gupnp.spec
SRPM URL: http://fedora.roving-it.com/rawhide/gupnp-0.10.1-1.fc9.src.rpm

Comment 2 Peter Robinson 2008-06-16 19:16:23 UTC
Updated to the latest release.

Spec URL: http://fedora.roving-it.com/rawhide/gupnp.spec
SRPM URL: http://fedora.roving-it.com/rawhide/gupnp-0.12-1.fc9.src.rpm

Comment 3 Peter Robinson 2008-06-30 22:59:30 UTC
Updated to the latest release.

Spec URL: http://fedora.roving-it.com/rawhide/gupnp.spec
SRPM URL: http://fedora.roving-it.com/rawhide/gupnp-0.12.1-1.fc9.src.rpm

Comment 5 Richard W.M. Jones 2008-08-08 15:21:33 UTC
I've taken this bug, but I'll wait to see a buildable package
from bug 446637 first.

Comment 6 Richard W.M. Jones 2008-08-12 13:04:55 UTC
I'm getting a build error on rawhide which looks like the same
problem we had with bug 446637:

gcc -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gssdp-1.0 -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I.. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -o .libs/light-client light-client.o  ../libgupnp/.libs/libgupnp-1.0.so
light-client.o: In function `main':
/home/rjones/rpmbuild/BUILD/gupnp-0.12.1/examples/light-client.c:79: undefined reference to `g_thread_init'
light-server.o: In function `main':
/homecollect2: ld returned 1 exit status
/rjones/rpmbuild/BUILD/gupnp-0.12.1/examples/light-server.c:96: undefined reference to `g_thread_init'
collect2: ld returned 1 exit status
make[2]: *** [light-client] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [light-server] Error 1

Comment 7 Peter Robinson 2008-08-13 09:14:46 UTC
applied a patch to stop the compile of the examples directory as its not installed/packaged anyway. Maintainers know about the issue and it will be fixed in the next release shortly.

SPEC: http://pbrobinson.fedorapeople.org/gupnp.spec
SRPM: http://pbrobinson.fedorapeople.org/gupnp-0.12.1-2.fc9.src.rpm

Comment 8 Richard W.M. Jones 2008-08-13 09:39:27 UTC
- rpmlint output

  gupnp.i386: W: incoherent-version-in-changelog 0.12-2 0.12.1-2.fc10

  The %changelog version numbers are incorrect.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
+ binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
+ header files should be in -devel
n/a static libraries should be in -static
+ packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
+ libfoo.so must go in -devel
+ -devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8


n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if available
- reviewer should build the package in mock
- the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
+ scriptlets should be sane
+ pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin

Just fix those %changelog version numbers and resubmit for approval.

Comment 9 Peter Robinson 2008-08-13 10:02:33 UTC
New spec and srpm fixing the changelog. BTW what rpmlint options did you use to get that reported so I can get more info for next time :)

SRPM: http://pbrobinson.fedorapeople.org/gupnp-0.12.1-3.fc9.src.rpm

Comment 10 Richard W.M. Jones 2008-08-13 10:18:15 UTC
OK, that fixes the rpmlint problem, so ===> APPROVED <===

I'm using rpmlint in Rawhide.  No special options.

Comment 11 Peter Robinson 2008-08-13 10:26:08 UTC
New Package CVS Request
Package Name: gupnp
Short Description: GUPnP is an framework for creating UPnP devices & control points
Owners: pbrobinson
Branches: F-8 F-9
InitialCC: pbrobinson
Cvsextras Commits: yes

Comment 12 Kevin Fenzi 2008-08-13 17:32:06 UTC
cvs done.

Comment 13 Peter Robinson 2008-08-13 18:24:55 UTC
Committed to CVS. Coming to a rawhide near you soon. Thanks for your help yet again Richard, feel free to swap any more reviews that you need :-)

Note You need to log in before you can comment on or make changes to this bug.