Description of problem:

The logrotate script of psacct runs "accton" always, independently of accounting
being enabled or not.



Version-Release number of selected component (if applicable):

psacct-6.3.2-41.1



How reproducible:

Always



Steps to Reproduce:
1. Turn accounting on by running "service psacct start"
2. Leave accounting on until there is some data on /var/account/pacct
3. Turn accounting off by running "service psacct stop"
4. Verify that /var/account/pacct stopped growing
5. Wait for logrotate to run (you should wait two days for this to occur
naturally); alternatively you can force this by running "logrotate -f
/etc/logrotate.conf"
6. Check that accounting is on again, see that /var/account/pacct is growing again



Actual results:

Accounting will be restarted any time that the logs rotate and there is any
content, independent of the service being started or not.



Expected results:

The postrotate script should run only when the service is started.



Additional info:

This problem could be fixed by changing the postrotate line of
/etc/logrotate.d/psacct

Instead of this:
        /usr/sbin/accton /var/account/pacct

It should be this:
        test -f /var/lock/subsys/psacct && /usr/sbin/accton /var/account/pacct