Bug 448102 - c++ broker sync() implementation incorrect with async store.
Summary: c++ broker sync() implementation incorrect with async store.
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: qpid-cpp
Version: beta
Hardware: All
OS: Linux
urgent
urgent
Target Milestone: ---
: ---
Assignee: Gordon Sim
QA Contact: Kim van der Riet
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-05-23 14:07 UTC by Alan Conway
Modified: 2009-05-07 20:09 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-28 16:04:29 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Alan Conway 2008-05-23 14:07:37 UTC
Description of problem:

On receiving a sync() command, the broker responds immediately. It does not wait
for async message enqueues to complete. This could give incorrect sync results
when used with the async store, causing hard-to-find intermittent bugs.

Summary of code changes:

 - Generalize IncompleteMessageList on SessionState to an incomplete command
list that can include both message enqueus and syncs.

 - Update subsequent pending syncs during message completion.

 - Send sync when all preceding async messages have completed.

Comment 1 Gordon Sim 2008-05-28 16:04:29 UTC
Current code actually already does what is required; on receiving a sync() the
broker will indeed wait until all outstanding enqueues are complete before
responding.


Note You need to log in before you can comment on or make changes to this bug.