Hide Forgot
Spec URL: http://www.alphatek.info/divers/php-pear-Net-IPv4.spec SRPM URL: http://www.alphatek.info/divers/php-pear-Net-IPv4-1.3.0-1.fc9.src.rpm Description: PHP library used for calculating IPv4 (AF_INET family) address information such as network as network address, broadcast address, and IP address. It's my first package (with https://bugzilla.redhat.com/show_bug.cgi?id=448204), I'm looking for a sponsor.
I can't sponsor you, I'm currently in the same boat as you currently but I did review the package. rpmlint showed no issues except for the lack of documentation. I don't see any issues with the packaging.
There is no documentation in the upstream code, so this should be normal.
New files: Spec URL: http://www.alphatek.info/divers/php-pear-Net-IPv4.spec SRPM URL: http://www.alphatek.info/divers/php-pear-Net-IPv4-1.3.0-2.fc9.src.rpm
As agreed with Chris, i take this review and will do steven spondoring
REVIEW : * rpmlint : W: no-documentation * The package is named according to the Package Naming Guidelines. * source files match upstream: 35ee77683b4fd34d7a9aa77c199b2eda Net_IPv4-1.3.0.tgz * The spec file name match the base package * The package must the PHP Packaging Guidelines * License field in the package spec file match the actual license * license is open source-compatible (PHP) * latest version is being packaged. * The spec file is written in American English * The spec file is legible * build in mock (F-9, noarch) * All build dependencies are listed in BuildRequires * no locales * no shared library files * package own all directories that it creates * Package don't own files or directories already owned by other packages * no duplicate files * Permissions on files are set properly * %clean section * package consistently use macros * The package contain code * no documentation * no library * no desktop file * %install, start with rm -rf %{buildroot} * All filenames are valid UTF-8 * scriptlets are sane * Final Provides ok php-pear(Net_IPv4) = 1.3.0 php-pear-Net-IPv4 = 1.3.0-2.fc9 * Final Requires ok /usr/bin/pear php-pear(PEAR) * install ok * work ok, with litle test case <?php require ("Net/IPv4.php"); $ip = Net_IPv4::parseAddress("192.168.0.4/24"); if ($ip) print_r($ip); else echo "failed\n"; ?> Should just change Remy to Remi in the changelog ;) APPROVED Please wait for you sponsoring before doing the CVS request.
New Package CVS Request ======================= Package Name: pear-Net-IPv4 Short Description: Class used for calculating IPv4 address information Owners: moixs Branches: F-9 InitialCC: moixs, remi Cvsextras Commits: yes
cvs done.
Sorry but I messed up, I used the alias instead of the real package name to create the CVS access. Could you destroy pear-Net-IPv4 CVS and create the following instead: New Package CVS Request ======================= Package Name: php-pear-Net-IPv4 Short Description: Class used for calculating IPv4 address information Owners: moixs Branches: F-9 InitialCC: moixs, remi Cvsextras Commits: yes
cvs done
php-pear-Net-IPv4-1.3.0-2.fc9 has been submitted as an update for Fedora 9
php-pear-Net-IPv4-1.3.0-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-pear-Net-IPv4'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-6636
php-pear-Net-IPv4-1.3.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Taking ownership according to http://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Deprecated_Package Package Change Request ====================== Package Name: php-pear-Net-IPv4 Owners: remi
Unretired, take ownership.
Package Change Request ====================== Package Name: php-pear-Net-IPv4 New Branches: el6 epel7 Owners: remi
Git done (by process-git-requests).