Bug 448205 (pear-Net-IPv4) - Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: pear-Net-IPv4
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-05-24 12:17 UTC by Steven Moix
Modified: 2014-01-21 13:50 UTC (History)
2 users (show)

Fixed In Version: 1.3.0-2.fc9
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-08-01 01:49:27 UTC
Type: ---
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Steven Moix 2008-05-24 12:17:35 UTC
Spec URL: http://www.alphatek.info/divers/php-pear-Net-IPv4.spec
SRPM URL: http://www.alphatek.info/divers/php-pear-Net-IPv4-1.3.0-1.fc9.src.rpm
Description: PHP library used for calculating IPv4 (AF_INET family) address information such as network as network address, broadcast address, and IP address.

It's my first package (with https://bugzilla.redhat.com/show_bug.cgi?id=448204), I'm looking for a sponsor.

Comment 1 David Hollis 2008-06-18 19:16:31 UTC
I can't sponsor you, I'm currently in the same boat as you currently but I did
review the package.  rpmlint showed no issues except for the lack of
documentation.  I don't see any issues with the packaging.

Comment 2 Steven Moix 2008-06-18 19:42:20 UTC
There is no documentation in the upstream code, so this should be normal.

Comment 4 Remi Collet 2008-07-13 07:42:05 UTC
As agreed with Chris, i take this review and will do steven spondoring

Comment 5 Remi Collet 2008-07-13 15:12:12 UTC
REVIEW :
* rpmlint :
W: no-documentation
* The package is named according to the Package Naming Guidelines.
* source files match upstream:
35ee77683b4fd34d7a9aa77c199b2eda  Net_IPv4-1.3.0.tgz
* The spec file name match the base package
* The package must the PHP Packaging Guidelines
* License field in the package spec file match the actual license 
* license is open source-compatible (PHP)
* latest version is being packaged.
* The spec file is written in American English
* The spec file is legible
* build in mock (F-9, noarch)
* All build dependencies are listed in BuildRequires
* no locales
* no shared library files
* package own all directories that it creates
* Package don't own files or directories already owned by other packages
* no duplicate files
* Permissions on files are set properly
* %clean section
* package consistently use macros
* The package contain code
* no documentation
* no library
* no desktop file
* %install, start with rm -rf %{buildroot}
* All filenames are valid UTF-8
* scriptlets are sane
* Final Provides ok
php-pear(Net_IPv4) = 1.3.0
php-pear-Net-IPv4 = 1.3.0-2.fc9
* Final Requires ok
/usr/bin/pear  
php-pear(PEAR)  
* install ok
* work ok, with litle test case

<?php
require ("Net/IPv4.php");
$ip = Net_IPv4::parseAddress("192.168.0.4/24");
if ($ip) print_r($ip);
else echo "failed\n";
?>


Should just change Remy to Remi in the changelog ;)

APPROVED

Please wait for you sponsoring before doing the CVS request.

Comment 6 Steven Moix 2008-07-14 08:07:07 UTC
New Package CVS Request
=======================
Package Name: pear-Net-IPv4
Short Description: Class used for calculating IPv4 address information
Owners: moixs
Branches: F-9
InitialCC: moixs, remi
Cvsextras Commits: yes

Comment 7 Kevin Fenzi 2008-07-14 16:05:58 UTC
cvs done.

Comment 8 Steven Moix 2008-07-14 17:29:21 UTC
Sorry but I messed up, I used the alias instead of the real package name to
create the CVS access. Could you destroy pear-Net-IPv4 CVS and create the
following instead:

New Package CVS Request
=======================
Package Name: php-pear-Net-IPv4
Short Description: Class used for calculating IPv4 address information
Owners: moixs
Branches: F-9
InitialCC: moixs, remi
Cvsextras Commits: yes

Comment 9 Toshio Ernie Kuratomi 2008-07-14 20:06:18 UTC
cvs done

Comment 10 Fedora Update System 2008-07-21 16:15:48 UTC
php-pear-Net-IPv4-1.3.0-2.fc9 has been submitted as an update for Fedora 9

Comment 11 Fedora Update System 2008-07-23 07:17:52 UTC
php-pear-Net-IPv4-1.3.0-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pear-Net-IPv4'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-6636

Comment 12 Fedora Update System 2008-08-01 01:49:25 UTC
php-pear-Net-IPv4-1.3.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Remi Collet 2012-04-02 14:00:15 UTC
Taking ownership according to 
http://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Deprecated_Package

Package Change Request
======================
Package Name: php-pear-Net-IPv4
Owners: remi

Comment 14 Gwyn Ciesla 2012-04-02 14:09:36 UTC
Unretired, take ownership.

Comment 15 Remi Collet 2014-01-18 13:15:57 UTC
Package Change Request
======================
Package Name: php-pear-Net-IPv4
New Branches: el6 epel7
Owners: remi

Comment 16 Gwyn Ciesla 2014-01-21 13:50:43 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.