Bug 448292 - Review Request: fbpanel - a lightweight X11 desktop panel
Summary: Review Request: fbpanel - a lightweight X11 desktop panel
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2008-05-25 14:24 UTC by Stefan Posdzich
Modified: 2012-04-21 20:57 UTC (History)
6 users (show)

Fixed In Version: fbpanel-6.1-4.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-06-20 19:12:04 UTC
Type: ---
mtasaka: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
fbpanel-4.12-libdir.patch (3.62 KB, patch)
2008-06-15 19:14 UTC, Robert Scheck
no flags Details | Diff

Description Stefan Posdzich 2008-05-25 14:24:14 UTC
Spec URL: http://files.spielen-unter-linux.de/repository/fedora/9/SRPMS/fbpanel.spec
SRPM URL: http://files.spielen-unter-linux.de/repository/fedora/9/SRPMS/fbpanel-4.12-1.fc9.src.rpm


fbpanel is a lightweight X11 desktop panel. It works with any ICCCM / NETWM 
compliant window manager (eg sawfish, metacity, openbox , xfwm4, kvm)
It features tasklist, pager, launcbar, clock, menu and sytray.

- This is my first package submission here.

Comment 1 Hemant Goyal 2008-06-06 17:22:37 UTC
Hi Stefan,

This is not a formal review but only a pre-review of your package. I am not
entitled to Sponsor you however, someone else will.

1] Please perform rpmlint <rpmname> on every package that you create.

The following rpmlint errors must be resolved
bpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/tray.so
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/test.so
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/cpu.so
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share
fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/menu.so
fbpanel.i386: E: arch-dependent-file-in-usr-share

2]Please note :

Every binary RPM package which stores shared library files (not just symlinks)
in any of the dynamic linker's default paths, must call ldconfig in %post and
%postun. If the package has multiple subpackages with libraries, each subpackage
should also have a %post/%postun section that calls /sbin/ldconfig. An example
of the correct syntax for this is:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

3] Packages containing GUI applications must include a %{name}.desktop file, and
that file must be properly installed with desktop-file-install in the %install
section. This is described in detail here
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files. If you feel
that your packaged GUI application does not need a .desktop file, you must put a
comment in the spec file with your explanation.


Comment 2 Stefan Posdzich 2008-06-07 01:01:58 UTC
Thank you Hemant for your feedback!
Here is my new version.

Spec URL: http://files.spielen-unter-linux.de/repository/fedora/9/SRPMS/
SRPM URL: http://files.spielen-unter-linux.de/repository/fedora/9/SRPMS/

Changelog: - fixed rpmlint errors, new .desktop file, cleanup

Comment 4 Mamoru TASAKA 2008-06-15 14:03:07 UTC
The srpm on comment 3 does not build.


Comment 5 Robert Scheck 2008-06-15 14:21:32 UTC
Yes, fbpanel-4.12-libs.patch seems a bit broken, tries %{_libdir} rather 
$RPM_BUILD_ROOT%{_libdir} or so.

Stefan, you're replacing "$(PREFIX)/share/fbpanel/plugins" by "/usr/lib/fbpanel/
plugins" but you should try "(PREFIX)/lib/fbpanel/plugins" instead for example.

Comment 6 Robert Scheck 2008-06-15 14:27:30 UTC
Oh, I forgot: This doesn't solve /usr/lib vs. /usr/lib64 anyway.

Comment 7 Robert Scheck 2008-06-15 19:14:28 UTC
Created attachment 309404 [details]

This patch should solve all issues regarding libraries in %{_datadir} and the
correct usage of %{_libdir} regarding /usr/lib vs. /usr/lib64. I think, I have
written it sane enough, so that maybe upstream also applies it.

Comment 8 Stefan Posdzich 2008-06-15 19:49:03 UTC
SPEC: http://cheekyboinc.spielen-unter-linux.de/fbpanel.spec
SRPM: http://cheekyboinc.spielen-unter-linux.de/fbpanel-4.12-3.fc9.src.rpm


- Solved build failure and broken libs-patch with patch from Robert Scheck

Thank you Robert and Mamoru for your feedback!

Comment 9 Mamoru TASAKA 2008-06-16 18:27:26 UTC
If no one beats me, I will try to look at this package tomorrow.

Comment 10 Mamoru TASAKA 2008-06-16 19:09:49 UTC
For 4.12-3:

* License
  - Well, actually I cannot understand why the upstream ships MIT
    license text...
bg.c			LGPLv2+
bg.h			LGPLv2+
ev.c			LGPLv2+
ev.h			LGPLv2+
gtkbar.c		LGPLv2+
gtkbar.h		LGPLv2+
gtkbgbox.c		LGPLv2+
gtkbgbox.h		LGPLv2+
plugins/cpu.c		GPLv2+
plugins/pager.c		GPLv2+
systray/eggtraymanager.c	LGPLv2+
systray/eggtraymanager.h	LGPLv2+
systray/fixedtip.c		GPLv2+
systray/fixedtip.h		GPLv2+
    I have not analysed how these codes are used/linked yet,
    however from a quick glance, the license tag must be
Group:		User Interface/Desktops
# %%{_bindir}/fbpanel and almost all plugins are under LGPLv2+
# Some plugins (cpu.so, pager.so, tray.so) are under GPLv2+
License:	LGPLv2+ and GPLv2+
URL:		http://fbpanel.sourceforge.net

* SourceURL
  - Please follow above.

  - Write the full URL of SOURCE2, or write as a comment how
    you received Source2.

* Redundant BuildRequires
  - gtk2-devel Requires atk-devel, pango-devel, cairo-devel so
    all these 3 BuildRequires are redundant.

* Timestamp
  - When using "cp" or "install" commands, add "-p" option to
    keep timestamps on installed files, like
install -p -m 0644 %{SOURCE2}	\

  - Also, as this package installs many image files and so on
    which are actually not modified during build, keeping 
    timestamps on those files are also perferred.
    To do so, please consider to use below:
sed -i.stamp -e 's|install -m|install -p -m|' \
	Makefile */Makefile
    at %prep stage.

* Debuginfo rpm missing
  - rpmlint complains about debuginfo rpm as below:
fbpanel-debuginfo.i386: E: empty-debuginfo-package
    debuginfo rpm is not created correctly. Several reasons are
    related to this.
    * Fedora specific compilation flags are not honored correctly.
    ! To check if compiler flags are correctly honored, please
      make build log more verbosely. The outputs like
    74  CC   systray/eggtraymanager.o
    75  DEP  plugins/space.dep
    76  DEP  plugins/pager.dep
    77  DEP  plugins/launchbar.dep
    78  CC   systray/fixedtip.o
    79  CC   plugin.o
    80  CC   gtkbar.o
      is not useful.
    * Makefile "strip" binaries to be installed. /usr/lib/rpm/find-debuginfo.sh
      strips installed binaries correctly and Makefiles themselves must
      not strip binaries.
    * Installed plugin objects has 0644 permission. As these objects are dlopened
      so these should work, however as find-debuginfo.sh strips binaries only
      with executable permissions, on Fedora these must have 0755 permission.

    The following will fix these 4 issues
    (please check what these changes actually do)
%setup -q
%patch -p1 -b .libdir
sed -i.strip -e 's|strip|true strip|' \
	Makefile */Makefile
sed -i.stamp -e 's|install -m|install -p -m|' \
	Makefile */Makefile

./configure --prefix=%{_prefix} --libdir=%{_lib}
make \
	%{?_smp_mflags} \
	Q= \

make install PREFIX=$RPM_BUILD_ROOT%{_prefix}
install -p -m 0644 %{SOURCE2}	\

find $RPM_BUILD_ROOT%{_libdir}/%{name} -name \*.so -print0 | \
	xargs -0 chmod 0755


* /sbin/ldconfig call
  - Calling /sbin/ldconfig on scriptlets is not needed for this
    package as no "libraries" are installed under default ldconfig

* Icon cache update
  - As icons are installed under %_datadir/icons/hicolor, please

Comment 11 Stefan Posdzich 2008-06-17 14:08:43 UTC
Wow, so...
Here is the new package.

SPEC: http://cheekyboinc.spielen-unter-linux.de/fbpanel.spec
SRPM: http://cheekyboinc.spielen-unter-linux.de/fbpanel-4.12-4.fc9.src.rpm


- Add correct url for Source:
- Add gtk-update-icon-cache
- Add timestamps
- Add missing debuginfo rpm
- Changed licence, MIT to LGPLv2+ and GPLv2+
- Remove unneeded ldconfig
- Remove redundant BuildRequires: atk-devel, pango-devel and cairo-devel

Comment 12 Mamoru TASAKA 2008-06-17 17:46:20 UTC
For 4.12-4:

* License analysis
  - Please also write license analysis I wrote on comment 10
    as comments in the spec file.

* Again Source2:
# image taken from the fbpanel source /config/images/star.png
Source2:	%{name}.png
  - Okay, then you don't have to add this file seperately to
    srpm. The following will be enough.
install -p -m 0644 config/images/star.png	\
    ! Note: This file has 128x128 size, not 32x32.

NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
(NOTE: please don't choose "Merge Review")

Review guidelines are described mainly on:

Comment 13 Stefan Posdzich 2008-06-18 00:00:23 UTC
SPEC: http://cheekyboinc.spielen-unter-linux.de/fbpanel.spec
SRPM: http://cheekyboinc.spielen-unter-linux.de/fbpanel-4.12-5.fc9.src.rpm


- Add comment about the license
- Remove redundant Source2:

You can find another package (review request) here:

XQF - A server browser for many popular games

Thank you Mamoru for your helpfull overview about the review process and all 
the other things. 

Comment 14 Mamoru TASAKA 2008-06-18 09:29:37 UTC

+ This package itself is good now
+ Your anothre review request seems good to some extent at a quick

            This package (fbpanel) is APPOVED by me

Please follow the procedure written on:
from "Get a Fedora Account".
At a point a mail should be sent to sponsor members which notifies
that you need a sponsor. At the stage, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 8/9, you also have
to look at
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Comment 15 Stefan Posdzich 2008-06-18 11:58:32 UTC
I finished the procedure in May.
I am member of cla_done and have requested the membership of cvsextras.
My FAS name is "cheekyboinc"


Okay, I will look at the koji and Bodhi system! 

Comment 16 Mamoru TASAKA 2008-06-18 12:19:59 UTC
Now I am sponsoring you. please follow "Join" wiki again.

Comment 17 Stefan Posdzich 2008-06-18 13:59:03 UTC
New Package CVS Request
Package Name: fbpanel
Short Description: a lightweight X11 desktop panel
Owners: cheekyboinc
Branches: F-8 F-9
Cvsextras Commits: yes

Comment 18 Kevin Fenzi 2008-06-19 00:30:27 UTC
cvs done.

Comment 19 Fedora Update System 2008-06-19 16:49:21 UTC
fbpanel-4.12-5.fc9 has been submitted as an update for Fedora 9

Comment 20 Fedora Update System 2008-06-19 16:53:13 UTC
fbpanel-4.12-5.fc8 has been submitted as an update for Fedora 8

Comment 21 Mamoru TASAKA 2008-06-19 17:42:28 UTC

Comment 22 Fedora Update System 2008-06-20 19:12:01 UTC
fbpanel-4.12-5.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2008-06-20 19:14:08 UTC
fbpanel-4.12-5.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 24 Damien Durand 2012-04-05 11:26:17 UTC
Package Change Request
Package Name: fbpanel
New Branches: el6
Owners: splinux

Comment 25 Gwyn Ciesla 2012-04-05 12:08:40 UTC
Git done (by process-git-requests).

Comment 26 Fedora Update System 2012-04-05 12:30:26 UTC
fbpanel-6.1-4.el6 has been submitted as an update for Fedora EPEL 6.

Comment 27 Fedora Update System 2012-04-21 20:57:25 UTC
fbpanel-6.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.