apcupsd src rpm contains apcupsd-3.14.1-init.patch, which includes: + condrestart) + [ -f /var/lock/subsys/ypbind ] && $0 restart || : + ;; What does /var/lock/subsys/ypbind have to do with apcupsd?
I'll fix this together with rebase to 3.14.4. Thanks for reporting.
BTW, you can use smp flags for make in 3.14.4, as makefile system was completely rewritten (and powerflute with nls removed).
apcupsd-3.14.4-1.fc9 has been submitted as an update for Fedora 9
apcupsd-3.14.4-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update apcupsd'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-4761
gettext-devel and ncurses-devel are no longer needed in spec file, as powerflute and nls were removed. Why an old patch apcupsd-3.14.1-cloexec.patch was added again? Wasn't it fixed in apcupsd 3.14.2? * Wed Oct 10 2007 - Orion Poplawski <orion.com> - 3.14.2-1 - Update to 3.14.2, remove upstreamed patches * Wed Aug 1 2007 - Orion Poplawski <orion.com> - 3.14.1-3 - Add patch to close open file descriptors (bug #247162) Install binaries: is still /usr/sbin, but according to bug #346271, if /usr is a separate filesystem, it will be unmounted at the point of killpower. Could you please install binaries in /sbin, as nut package does?
I have added the cloexec patch back for I failed to find the changes in the upstream code and I'll take a look at moving the binaries to /sbin.
This was fixed upstream in a different way: src/lib/apcexec.c:178: /* Don't leak unnecessary fds to child */ for (int i=0; i<sysconf(_SC_OPEN_MAX); i++) { if (i != STDIN_FILENO && i != STDOUT_FILENO && i != STDERR_FILENO) { if (close(i) == 0) Dmsg1(200, "exec closed fd %d\n", i); } }
Thanks. I'll drop the path again then.
apcupsd-3.14.4-2.fc9 has been submitted as an update for Fedora 9
apcupsd-3.14.4-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.