Bug 448867 (perl-parent) - Review Request: perl-parent - Establish an ISA relationship with base classes at compile time
Summary: Review Request: perl-parent - Establish an ISA relationship with base classes...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-parent
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/parent/
Whiteboard:
Depends On:
Blocks: 439706 perl-duallifed
TreeView+ depends on / blocked
 
Reported: 2008-05-29 05:37 UTC by Chris Weyl
Modified: 2012-02-23 23:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-19 17:16:31 UTC
Type: ---
tibbs: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-05-29 05:37:11 UTC
SRPM URL: http://fedora.biggerontheinside.net/review/perl-parent-0.221-1.fc9.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-parent.spec

Description:
Allows you to both load one or more modules, while setting up inheritance
from those modules at the same time. Mostly similar in effect to:

    package Baz;

    BEGIN {
        require Foo;
        require Bar;

        push @ISA, qw(Foo Bar);
    }

Comment 1 Chris Weyl 2008-05-29 05:38:30 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=634256

This package is a new dep of Catalyst::Devel 0.106.

Comment 2 Jason Tibbitts 2008-06-18 20:11:43 UTC
Really nothing to say here.

* source files match upstream:
   a04211e6fb2bf12913c63f904483550554013737ed8e1302fcbadca22ed3509e  
   parent-0.221.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(parent) = 0.221
   perl-parent = 0.221-1.fc10
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(strict)
   perl(vars)

* %check is present and all tests pass:
   All tests successful.
   Files=7, Tests=34,  0 wallclock secs ( 0.13 cusr +  0.03 csys =  0.16 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 3 Chris Weyl 2008-06-18 20:46:01 UTC
New Package CVS Request
=======================
Package Name: perl-parent
Short Description: Establish an ISA relationship with base classes at compile time
Owners: cweyl
Branches: F-8, F-9, devel
InitialCC: perl-sig

Comment 4 Jason Tibbitts 2008-06-19 00:32:52 UTC
CVS done.

Comment 5 Chris Weyl 2008-06-19 17:16:31 UTC
Imported and building.  Thanks for the review :)

Comment 6 Paul Howarth 2012-02-07 19:48:59 UTC
Package Change Request
======================
Package Name: perl-parent
New Branches: EL-5
Owners: pghmcfc
InitialCC: perl-sig

I'm not requesting an EL-6 branch as this package is included in RHEL-6.

Comment 7 Gwyn Ciesla 2012-02-07 19:55:38 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2012-02-07 21:08:53 UTC
perl-parent-0.225-6.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-parent-0.225-6.el5

Comment 9 Fedora Update System 2012-02-23 23:03:32 UTC
perl-parent-0.225-6.el5 has been pushed to the Fedora EPEL 5 stable repository.


Note You need to log in before you can comment on or make changes to this bug.