Bug 449707 - Review Request: gambit-c - Gambit-C Scheme programming system
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 450417 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-03 01:59 UTC by Michel Lind
Modified: 2008-08-01 01:47 UTC (History)
3 users (show)

Fixed In Version: 4.2.8-6.fc9
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-08-01 01:46:36 UTC
Type: ---
Embargoed:
j: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Michel Lind 2008-06-03 01:59:54 UTC
Spec URL: http://salimma.fedorapeople.org/for_review/lang/gambit-c.spec
SRPM URL: http://salimma.fedorapeople.org/for_review/lang/gambit-c-4.2.8-1.fc9.src.rpm
Description:
Gambit-C includes a Scheme interpreter and a Scheme compiler which can
be used to build standalone executables.  Because the compiler
generates portable C code it is fairly easy to port to any platform
with a decent C compiler.

The Gambit-C system conforms to the R4RS, R5RS and IEEE Scheme
standards.  The full numeric tower is implemented, including: infinite
precision integers (bignums), rationals, inexact reals (floating point
numbers), and complex numbers.

(based on earlier third-party package by Gerard Milmeister)

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=642058

Note that this is not for the submitted package; I've since split out the HTML and PDF documentations into a -doc subpackage (almost 2 MB)

Comment 1 Jason Tibbitts 2008-06-06 19:59:39 UTC
This builds OK; rpmlint has several devel-file-in-non-devel-package complaints,
which can be ignored because this is a compilation system.  There are also these:
  gambit-c-debuginfo.x86_64: W: spurious-executable-perm 
   /usr/src/debug/gambc-v4_2_8/lib/mem.c
  gambit-c-debuginfo.x86_64: W: spurious-executable-perm 
   /usr/src/debug/gambc-v4_2_8/lib/setup.h
which aren't a big deal but trivially fixed with a chmod in %prep if you care.

I'm not sure about the license.  ASL 2.0 is certainly correct, but it seems to
me that they allow LGPLv2+, not just LGPLv2.  Am I missing something?  I don't
see anywhere in the source that a specific LGPL version is specified, and if you
click the link on their web site you go to FSF's LGPLv3 page.  Perhaps you could
get them to clarify.

There seems to be a test suite present which isn't called.  I added 
  %check
  make check
and it runs fine, ending with:
  ============ ALL TESTS SUCCESSFUL

Note that /usr/bin/six conflicts with the existing (and completely unrelated)
six package.  Is there any possibility of renaming it?

Did you consider moving the info documentation and the examples to gambit-c-doc
as well?  The examples, at least, are almost another megabyte, although that's
dwarfed by the rest of the package.

* source files match upstream:
   e07d0031e434fc98a8b3ac136fe2426280cc342b8e3b3a325c7348938d5bae11  
   gambc-v4_2_8.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
? license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has trivial complaints.
* final provides and requires are sane:
  gambit-c-4.2.8-1.fc10.x86_64.rpm
   gambit-c = 4.2.8-1.fc10
  =
   /bin/sh
   gcc
   info
   libutil.so.1()(64bit)
   libutil.so.1(GLIBC_2.2.5)(64bit)

  gambit-c-doc-4.2.8-1.fc10.x86_64.rpm
   gambit-c-doc = 4.2.8-1.fc10
  =
   gambit-c = 4.2.8-1.fc10

X %check is not present, but a functional test suite exists.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
O file perms in the -debuginfo package are a bit odd; everything else is OK.
* scriptlets OK (install-info).
* code, not content.
* %docs are not necessary for the proper functioning of the package.
* headers present, but OK since this is a compiler.
* no pkgconfig files.
* static libraries present, but OK since this is a compilation system.
* no libtool .la files.

Comment 2 Michel Lind 2008-06-07 15:24:57 UTC
Spec URL: http://salimma.fedorapeople.org/for_review/lang/gambit-c.spec
SRPM URL:
http://salimma.fedorapeople.org/for_review/lang/gambit-c-4.2.8-2.fc9.src.rpm

Suggestions implemented, thanks. I also removed some of the symlinks that turns
out to be superfluous -- only gsi, gsc and six are really needed. six just links
to gsi anyway (gsi switches to infix mode if it's called as six, so I've created
a wrapper script, gsix, that invokes the six symlink from %{_libdir})

Will check with upstream on the license question.

Comment 3 Michel Lind 2008-06-08 01:59:34 UTC
FYI, I'm also packaging gambit-termite
(https://bugzilla.redhat.com/show_bug.cgi?id=450417), the same Gambit-C with the
Termite distributed programming system patched in. I've packaged it to be
completely parallel-installable.

Comment 4 Jason Tibbitts 2008-06-10 20:13:52 UTC
Hmm, this one didn't build for me:
  + chmod +x gsix
  chmod: cannot access `gsix': No such file or directory

Oh, that needs to be:
  chmod +x $RPM_BUILD_ROOT%{_bindir}/gsix

Otherwise (fixing the above so that it builds), things look good.  The test
suite is run and passes; the conflict with /usr/bin/six is gone, and the weird
permissions are fixed up.

I guess we're just waiting on the license.  I don't know if it's something that
should hold up this package, so I'll approve it and you can check in when you
get an answer.  If you don't, it seems clear due to the "any later version"
language that LGPLv2+ is correct here.

APPROVED

An odd question, perhaps, but have you considered just having this package
generate gambit-termite as well?  I guess that might be a weird build process,
though.

Comment 5 Michel Lind 2008-06-18 16:49:24 UTC
That's a thought, that way they can just share documentation.

New Package CVS Request
=======================
Package Name: gambit-c
Short Description: Gambit-C Scheme programming system
Owners: salimma
Branches: F-8 F-9 EL-5
InitialCC:
Cvsextras Commits: yes


Comment 6 Jason Tibbitts 2008-06-19 02:52:03 UTC
CVS done.

Comment 7 Fedora Update System 2008-07-05 05:29:15 UTC
gambit-c-4.2.8-5.fc9 has been submitted as an update for Fedora 9

Comment 8 Fedora Update System 2008-07-05 07:12:43 UTC
gambit-c-4.2.8-5.fc8 has been submitted as an update for Fedora 8

Comment 9 Maxime CARRON 2008-07-05 10:15:15 UTC
Is there any reason why you don't use --enable-gcc-opts

INSTALL.txt says :
"When using the GCC compiler it is recommended to use the
--enable-gcc-opts option to further improve the execution speed and
compactness of the executables"

Comment 10 Fedora Update System 2008-07-06 06:12:03 UTC
gambit-c-4.2.8-5.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update gambit-c'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-6115

Comment 11 Michel Lind 2008-07-06 16:44:42 UTC
*** Bug 450417 has been marked as a duplicate of this bug. ***

Comment 12 Michel Lind 2008-07-14 20:21:11 UTC
Maxime:

--enable-gcc-opts is enabled in the version I committed -- I did not turn it on
in the version reviewed, and did not update it after the review was approved.

Comment 13 Fedora Update System 2008-07-15 16:03:02 UTC
gambit-c-4.2.8-6.fc9 has been submitted as an update for Fedora 9

Comment 14 Fedora Update System 2008-07-15 17:13:48 UTC
gambit-c-4.2.8-6.fc8.1 has been submitted as an update for Fedora 8

Comment 15 Fedora Update System 2008-08-01 01:46:32 UTC
gambit-c-4.2.8-6.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2008-08-01 01:47:27 UTC
gambit-c-4.2.8-6.fc8.1 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.