Bug 449812 - gnbd does explicitly disallow sending requests after a send has failed.
Summary: gnbd does explicitly disallow sending requests after a send has failed.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: gnbd-kmod
Version: 5.2
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Ben Marzinski
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks: 391501
TreeView+ depends on / blocked
 
Reported: 2008-06-03 18:42 UTC by Ben Marzinski
Modified: 2018-10-20 02:46 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-20 21:08:25 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
patch to disallow sending requests after a send has failed. (1.68 KB, patch)
2008-06-03 18:50 UTC, Ben Marzinski
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2009:0215 0 normal SHIPPED_LIVE gnbd-kmod bug fix update 2009-01-20 16:06:21 UTC

Description Ben Marzinski 2008-06-03 18:42:51 UTC
Description of problem:
GNBD assumes that after a send to a socket has a failed due to a socket error,
future sends or receives on the socket will also fail.  If this doesn't happen,
it is possible to send garbage to the gnbd server.

Version-Release number of selected component (if applicable):
gnbd-1.1.5-1.el5

How reproducible:
Not sure.  A customer has seen GNBD_REQUEST_MAGIC mismatched errors likely
stemming from this.

Additional info:
This bug was initially mentioned in comment #14 of bz #444074, but it is
unrelated to the issue that the bugzilla was opened to track.

Comment 1 Ben Marzinski 2008-06-03 18:50:20 UTC
Created attachment 308279 [details]
patch to disallow sending requests after a send has failed.

This patch adds a "corrupt" flag to the gnbd device structure.	This flag is
cleared when a new socket connection is opened to the server. It is set
whenever
a send fails.  After this all future sends will fail, and the receiver process
will stop accepting replies as soon as it notices the flag.

Comment 2 RHEL Program Management 2008-06-05 19:54:45 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 5 Fedora Update System 2008-07-30 20:03:49 UTC
gfs2-utils-2.03.05-1.fc9, rgmanager-2.03.05-1.fc9, cman-2.03.05-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 errata-xmlrpc 2009-01-20 21:08:25 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0215.html


Note You need to log in before you can comment on or make changes to this bug.