Red Hat Bugzilla – Bug 449842
Review Request: trac-xmlrpc-plugin - XML-RPC plugin for Trac
Last modified: 2013-01-09 22:20:32 EST
Spec URL: http://jkeating.fedorapeople.org/review/trac-xmlrpc-plugin.spec
SRPM URL: http://jkeating.fedorapeople.org/review/trac-xmlrpc-plugin-0.1-0.1.20080528svn3074.fc9.src.rpm
This Trac plugin provides support for xmlrpc.
Per comment on Bug #449840:
I'll pick up this review, I believe you need to depend on
python-setuptools-devel now (per
Ricky's python-dictclient spec file recently passed review w/ it doing this way
as an example.
Full review coming up.
Y: rpmlint on each package
trac-xmlrpc-plugin.noarch: W: no-documentation
Y: Meets Package Naming Guidelines
Y: Spec file name matches base package name
Y: License field is valid
Y: Meets Packaging Guidelines
-: License included in package (if included in source)
Y: Spec file written in en_US
Y: Spec file is legible
Y: Sources match upstream source
Y: Source URL 'sane'
Y: Compiles successfully - [F9 (noarch), Rawhide (noarch)]
-: ExcludeArch required?
Y: All Build Dependencies Listed
-: Handles locales sanely
-: Library packages run ldconfig
Y: Package is not relocatable
-: Package owns all directories created
Y: No duplicate file listings
Y: defattr set correctly
Y: %clean is used
Y: Macro use conisistant
Y: Contains Code/Content that is allowed
-: Large Documentation in -doc subpackage
Y: %doc must not affect package runtime
-: Header files in -devel
-: Static libraries in -static
-: pkgconfig files require pkgconfig
-: Library files are located in correct package
-: -devel requires base package w/ fully versioned dependency
-: Packages do not contact .la (libtool) archives
-: GUI Apps have .desktop files
Y: No duplicate directory ownerships
Y: %install cleans buildroot
Y: Filenames are valid UTF-8
-: Description/Summary sections contain translations
Y: Builds in mock/koji
Y: Builds on all architectures
-: Scriptlets are sane
-: Subpackages require base package
-: pkgconfig.pc files in -devel
-: File dependencies should only be in /etc /bin /sbin /usr/bin /usr/sbin
Same moans as with Bug #449840, lack of COPYING file but this time, no
documentation at all, non blocker though.
It'd be nice to see python-setuptools-devel pulled in by BR but as mentioned, it
doesn't block the build.
Here's your APPROVED ticket, please take it to the next counter (CVS).
After investigation, it is no longer necessary to pull in
python-setuptools-devel. That's only necessary if you want the command line
executed easy_install, which we do not need since we're using python setup.py
and setuptools directly.
New Package CVS Request
Package Name: trac-xmlrpc-plugin
Short Description: XML-RPC plugin for Trac
Cvsextras Commits: yes
Turns out this was already in Fedora, closing it.