Red Hat Bugzilla – Bug 449962
Review Request: tex-fonts-hebrew - Support using (Culmus) Hebrew fonts in TeXLive
Last modified: 2008-07-06 12:29:03 EDT
Spec URL: http://www.cs.technion.ac.il/~danken/texlive-fonts-hebrew.spec
SRPM URL: http://www.cs.technion.ac.il/~danken/texlive-fonts-hebrew-0.1-9.fc9.src.rpm
Description: Support using the Culmus Hebrew fonts in TeXLive!
(minor conversion of tetex-fonts-hebrew)
The naming of tex packages is now
Thanks, but why do
and its likes suggest otherwise?
Well, texlive is itself a distribution and has many subpackages, but this is not
a texlive subpackage. Previously Fedora used tetex, and thus you will see many
tetex-* package still in the distribution, but due to the change we prefer to
have a tex-distribution-neutral naming scheme; hence, tex-fonts-hebrew.
See http://fedoraproject.org/wiki/Packaging/Minutes20071002 for the packaging
committee decision. Unfortunately I think this fell through the cracks and
wasn't ever written into the guidelines anywhere; if you'd prefer to to wait
until that is done and I can refer you directly to the guidelines, I'd understand.
Anyway, this package builds OK; rpmlint has the following complaints:
W: file-not-utf8 /usr/share/doc/texlive-fonts-hebrew-0.1/hebhello.tex
Normally we fix these up, but I'm not sure what to do with tex files.
W: dangling-relative-symlink /usr/share/texmf/fonts/type1/public/culmus
W: dangling-relative-symlink /usr/share/texmf/fonts/afm/public/culmus
It's OK to have links to files in other packages as long as they're pulled in
via dependencies, which is the case here since fonts-hebrew, a dependency, will
pull in culmus-fonts.
W: invalid-license GPL
Please use an appropriate License: tag from http://fedoraproject.org/wiki/Licensing.
W: obsolete-not-provided tetex-fonts-hebrew
If you want to replace the existing tetex-fonts-hebrew package, you need to
provide a proper upgrade path. See
for more information.
Thanks for the quick review. I think I answer your comments in
Please tell me if you find somthing to the contrary.
Sorry for taking so long; I was distracted by another project. At least I
remember why this seems so familiar; I reviewed tetex-fonts-hebrew a couple of
years ago. We have a few new guidelines since then, and I might have missed a
couple of things, so there are a few issues even though this package is mostly
rpmlint is down to the file-not-utf8 and two dangling-relative-symlink
complaints. I think these are all OK.
I know you're maintaining the tarball yourself; we have a guideline about that
now. Please see http://fedoraproject.org/wiki/Packaging/SourceURL (the "We are
I'm not sure the License: is correct. There is a GPL notice, but as far as I
can tell, nothing in the package specifies a version, so by the language in the
GPL notice any GPL version is acceptable (and hence the License: tag should
contain GPL+). Also, the file "hebrew.ldf" seems to be under the LPPL. If
that's correct then it seems to me that you should have:
License: GPL+ and LPPL
with a comment before that indicating which parts are under which license. But
I could be missing something.
The Summary isn't actually correct on F9 at least, because teTeX isn't in use there.
The /usr/share/texmf/fonts/enc/dvips/culmus directory seems to be unowned.
X source files can't be compared with upstream sources.
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
X summary shouldn't mention tetex.
* description is OK.
* dist tag is present.
* build root is OK.
X license field doesn't seem to match the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
tetex-fonts-hebrew = 0.1-9.fc10
tex-fonts-hebrew = 0.1-9.fc10
X fails to own /usr/share/texmf/fonts/enc/dvips/culmus
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Don't worry about small delays; now that I have this package working on my own
machine I'm in no hurry.
I hope that I answered all your comments. (mainly added comments to the spec...)
Please review the same URLs again.
Things look good to me:
/usr/share/texmf/fonts/enc/dvips/culmus is owned properly.
The License: looks good.
Summary looks good.
Lack of upstream sources is commented properly.
New Package CVS Request
Package Name: tex-fonts-hebrew
Short Description: Support using (Culmus) Hebrew fonts in TeXLive
Cvsextras Commits: yes
tex-fonts-hebrew-0.1-9.fc9 has been submitted as an update for Fedora 9
tex-fonts-hebrew-0.1-9.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please don't leave review tickets open after they're done — thanks