Bug 450514 - times does not set errno adn return -1 for EFAULT
Summary: times does not set errno adn return -1 for EFAULT
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: glibc
Version: 9
Hardware: i386
OS: Linux
low
low
Target Milestone: ---
Assignee: Jakub Jelinek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-09 11:36 UTC by Martin Suesskraut
Modified: 2008-06-09 11:49 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-09 11:49:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
C code to demonstrate bug. (190 bytes, text/plain)
2008-06-09 11:36 UTC, Martin Suesskraut
no flags Details

Description Martin Suesskraut 2008-06-09 11:36:12 UTC
Description of problem:
Calling function times with some invalid non-NULL pointer, does not return -1
and set errno to EFAULT.

Version-Release number of selected component (if applicable):
2.8

How reproducible:
Compile attached C-code and run it.

Steps to Reproduce:
1. Compile attached C-file with "gcc times.c -o times -Wall"
2. run ./times
3.
  
Actual results:
prints:
"times: -14 errno: 0"

Expected results:
times: -1 errno: 14

Additional info:
It seams, that the wrapper for the times-syscall passes the return value of the
kernel directly to the caller instead of testing for an error.

Comment 1 Martin Suesskraut 2008-06-09 11:36:12 UTC
Created attachment 308676 [details]
C code to demonstrate bug.

Comment 2 Jakub Jelinek 2008-06-09 11:49:27 UTC
That's because kernel returns the same return value when the argument is valid,
but clock_t is -14L.  rawhide glibc has more complicated wrapper that will
segfault if the argument is invalid.  No matter what, relying on -1/EFAULT is
just wrong.


Note You need to log in before you can comment on or make changes to this bug.