Bug 450684 - Ignored return value from syscall in gfs_controld/util.c
Summary: Ignored return value from syscall in gfs_controld/util.c
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: cman
Version: 10
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: David Teigland
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-10 12:56 UTC by Steve Whitehouse
Modified: 2009-07-23 13:16 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-07-23 13:16:54 UTC
Type: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Steve Whitehouse 2008-06-10 12:56:59 UTC 
From the last few lines of set_sysfs():

        rv = write(fd, out, strlen(out));

        close(fd);
        return 0;
}

Need to audit any similar code for the same bug.
Comment 1 Fabio Massimo Di Nitto 2008-06-10 13:07:07 UTC 
Some of those are already catched by Fedora build flag.

I already suggested different times to switch to -Werror and fix all build
warning, but i was turned down.

Perhaps it's about time to do it.

Fabio
Comment 2 Steve Whitehouse 2008-06-10 13:16:08 UTC 
There is no excuse for not fixing this kind of thing. If you get "turned down"
again, point me at the culprit and I'll moan at them until they give in :-)
Comment 3 John Poelstra 2008-10-18 04:04:45 UTC 
What version of the package has these issues?
Comment 4 Steve Whitehouse 2008-10-20 09:03:19 UTC 
Upstream/rawhide, i.e. the latest version
Comment 5 Bug Zapper 2008-11-26 02:24:03 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle.
Changing version to '10'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping
Comment 6 Steve Whitehouse 2009-07-23 13:16:54 UTC 
This was fixed ages ago.
Note You need to log in before you can comment on or make changes to this bug.