Bug 450802
| Summary: | Hwcert catalog's postdate cron job should run more than once a day to support setting "today" as the post date. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Hardware Certification Program | Reporter: | XINSUN <xisun> | ||||||
| Component: | Hardware Catalog | Assignee: | XINSUN <xisun> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yu Shao <yshao> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 5 | CC: | averma, bxu, efeng, rlandry, xiqin, ykun, yshao | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | http://https://hardware.redhat.com/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 3.2rh-20080801.1 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2008-08-04 17:56:53 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
XINSUN
2008-06-11 03:08:29 UTC
The reason caused this bug is:
The postdate cron job runs at 00:01 EST (mid-night once everyday) to query
and process the certs which were closed and their postdate <= NOW().
Once someone sets "today" (eg.6/9) as the postdate at 6/9 01:57 EST which is
after the 6/9's cron runs time ("00:01"). It will be missed and processed by the
next day (6/10 00:01 EST).
My idea is that run the postdate cron job for "every 30 mins" or "twice in a
day("00:01","23:59")" to support setting today as post date.
"every 30 mins":
*/30 * * * * root cd /var/www/html/hwcert; ./postdate.pl 2> /dev/null
or
"twice in a day":
1 0 * * * root cd /var/www/html/hwcert; ./postdate.pl 2> /dev/null
59 23 * * * root cd /var/www/html/hwcert; ./postdate.pl 2> /dev/null
Pls give me some your suggestion. "every 30 mins" or "twice in a day" or other
thought, even maybe we may deny user to set postdate as today. :)
Best Regards!
Nicho
Sounds like the once a day would work if we were to go ahead and block "today" as a choice from the dialog. The interface should default to tomorrow and then error if a date =< today is submitted. It sounds like that would solve the issue seen? Created attachment 311242 [details]
Patch Fix:
Deny user to set the today as posting date.
Suggested error message "The selected posting date is not in the future. Press back to select another date." Created attachment 312158 [details]
Patch Improve:
Follow Rob's suggestion and change the error message.
thanks a lot :)
Best Regards!
nicho
Looks good to me, if it's tested to work, I think it can be checked in. Also please don't forget to post to the mailing list the bug# and the patch (attach id should be fine) so the people on the list know to review it. verified and run good |