Bug 450836 - Ignoring return value in gfs_mkfs
Summary: Ignoring return value in gfs_mkfs
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: GFS
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Robert Peterson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-11 09:42 UTC by Steve Whitehouse
Modified: 2008-06-19 05:22 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-19 05:22:56 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Proposed patch (586 bytes, patch)
2008-06-12 17:12 UTC, Robert Peterson 		no flags Details | Diff
View All

Description Steve Whitehouse 2008-06-11 09:42:49 UTC 
From the is64 build logs:

gcc -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -Wall -Wformat=2 -MMD -O2 -g
-I/usr/src/upstream/cluster/rhcluster/cluster/make
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DLOGDIR=\"/var/log/cluster\" -DSYSLOGFACILITY=LOG_LOCAL4
-DRELEASE_VERSION=\"2.99.03\" -Wall -Wformat=2 -MMD -O2 -g
-I/usr/src/upstream/cluster/rhcluster/cluster/make
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DLOGDIR=\"/var/log/cluster\" -DSYSLOGFACILITY=LOG_LOCAL4
-DRELEASE_VERSION=\"2.99.03\" -Wall -Wformat=2 -MMD -O2 -g
-I/usr/src/upstream/cluster/rhcluster/cluster/make
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DLOGDIR=\"/var/log/cluster\" -DSYSLOGFACILITY=LOG_LOCAL4
-DRELEASE_VERSION=\"2.99.03\" -DHELPER_PROGRAM -D_FILE_OFFSET_BITS=64
-I/usr/src/upstream/cluster/rhcluster/cluster/gfs-kernel/src/gfs -I/usr/include
-I/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/../include
-I/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/../libgfs
-I/usr/include -c -o main.o
/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/main.c
/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/main.c: In function
'are_you_sure':
/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/main.c:224: warning:
ignoring return value of 'fgets', declared with attribute warn_unused_result
Comment 1 Robert Peterson 2008-06-12 17:12:46 UTC 
Created attachment 309108 [details]
Proposed patch

Here is the patch I've tested on x86_64 and ia64.  I'll be pushing it
shortly.
Comment 2 Robert Peterson 2008-06-12 17:25:45 UTC 
Now pushed to master and STABLE2.
Note You need to log in before you can comment on or make changes to this bug.