Bug 450921 - s2io intr_type documentation inaccurate
s2io intr_type documentation inaccurate
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
5.2
All Linux
low Severity low
: rc
: ---
Assigned To: Michal Schmidt
Martin Jenner
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-11 14:15 EDT by Andrew Hecox
Modified: 2009-01-20 15:25 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-20 15:25:10 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Andrew Hecox 2008-06-11 14:15:01 EDT
... from Documentation/networking/s2io.txt

e. intr_type
Specifies interrupt type. Possible values 1(INTA), 2(MSI), 3(MSI-X)
Valid range: 1-3

in fact, there are only two options, 0 (INTA) and 2 (MSI_X)

ahecox@honeypot ~ $ grep -E "define (MSI_X|MSI|INTA)" drivers/net/s2io.h
#define INTA    0
#define MSI_X   2

I believe Neterion XFrame I supported only INTA, XFrame II and later MSI-X. It
would be nice to have this documentation (upstream too) corrected.
Comment 1 Michal Schmidt 2008-06-16 11:55:01 EDT
Indeed the documentation is wrong. Should be no problem getting it fixed
upstream. I'll take care of it. Devel ACK.
Comment 2 RHEL Product and Program Management 2008-06-16 11:59:39 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 4 Michal Schmidt 2008-06-27 09:59:57 EDT
Patch sent upstream: http://marc.info/?l=linux-netdev&m=121448926721877&w=2
It's now in Dave Miller's git tree.

I posted the patch to rhkernel-list too, with the only difference being the
default value of the parameter (it's 2(MSI_X) in upstream and 0(INTA) in RHEL).
Comment 5 Don Zickus 2008-07-23 14:55:49 EDT
in kernel-2.6.18-99.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5
Comment 9 errata-xmlrpc 2009-01-20 15:25:10 EST
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html

Note You need to log in before you can comment on or make changes to this bug.