Bug 451008 - Rpmbuild generates incorrect packages due to typos in the kernel-2.6.spec file.
Rpmbuild generates incorrect packages due to typos in the kernel-2.6.spec file.
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
5.2
All Linux
low Severity low
: rc
: ---
Assigned To: Jarod Wilson
Martin Jenner
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-12 07:31 EDT by Alan Bartlett
Modified: 2009-01-20 15:24 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-20 15:24:33 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch to correct typos in kernel spec file. (1.18 KB, patch)
2008-06-12 07:33 EDT, Alan Bartlett
no flags Details | Diff

  None (edit)
Description Alan Bartlett 2008-06-12 07:31:26 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14

Description of problem:
There are two typos in the spec file which result in debug and debuginfo being selected regardless of the use of either --without debug or --without debuginfo flags on the rpmbuild command line.

Version-Release number of selected component (if applicable):
kernel-2.6.18-92.el5.src.rpm

How reproducible:
Always


Steps to Reproduce:
1.rpmbuild -bb --target=`uname -m` --with baseonly --without debuginfo kernel-2.6.spec
2.
3.

Actual Results:
The debug packages are incorrectly built as well as the kernel-2.6.18-92.el5.rpm and kernel-devel-2.6.18-92.el5.rpm packages.

Expected Results:
Only the kernel-2.6.18-92.el5.rpm and kernel-devel-2.6.18-92.el5.rpm should be built.

Additional info:
A patch has been written to correct the errors in the kernel-2.6.spec file.
Comment 1 Alan Bartlett 2008-06-12 07:33:20 EDT
Created attachment 309051 [details]
Patch to correct typos in kernel spec file.
Comment 2 Akemi Yagi 2008-06-12 11:24:59 EDT
These errors have been there from day one, and amazingly no one had noticed
until now.  Look at comment #42 of bug#240878 (or even comment #35) that was
almost a year ago.
Comment 3 Alan Bartlett 2008-06-12 11:52:07 EDT
Also obvious on inspection of comment #50 of bug#240878.
Comment 4 Jarod Wilson 2008-06-13 09:48:32 EDT
The inversions should be corrected, but in my experience, they don't actually
cause any failure of intended use. At least, they don't with Fedora kernel
builds, where we have the same inversion. I'd give it a try with the RHEL5
kernel, but its probably not worth the effort, since we ought to fix that
regardless... :)
Comment 5 Alan Bartlett 2008-06-16 06:32:52 EDT
Anyone with a 

%_enable_debug_packages 0 

line in their .rpmmacros file (such as I had) will not see this issue. It was
only on removing that line to test the 

--without debugpackages

command line flag, new with the *-92.el5 kernel series, did it become apparent
to me.

Thanks for correcting this.
Comment 7 RHEL Product and Program Management 2008-07-22 14:43:13 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 9 Don Zickus 2008-07-23 14:55:51 EDT
in kernel-2.6.18-99.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5
Comment 10 Alan Bartlett 2008-07-24 04:46:44 EDT
Looking at the beginning of the spec file for the -99.el5 kernel, I see it is
now as I would expect it to be.

Thanks.
Comment 11 Alan Bartlett 2008-07-24 17:24:41 EDT
I can now confirm that a build using the --with baseonly option on the command
line performs correctly. Just the base kernel and its corresponding kernel-devel
rpm files are built.

rpmbuild -bb --target i686 --with baseonly kernel-2.6.spec

builds kernel-2.6.18-99.el5.i686.rpm and kernel-devel-2.6.18-99.el5.i686.rpm
Comment 12 Don Zickus 2008-09-15 14:14:07 EDT
Reverting back to MODIFIED.  Please do not set to VERIFIED until QE sends instructions doing so.  They have to make sure the patch makes it into a potential 5.3 distribution first.
Comment 16 errata-xmlrpc 2009-01-20 15:24:33 EST
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html

Note You need to log in before you can comment on or make changes to this bug.