Bug 451302 - Review Request: kopete-bonjour
Summary: Review Request: kopete-bonjour
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2008-06-13 19:05 UTC by Tejas Dinkar
Modified: 2008-12-14 06:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-12-14 06:04:19 UTC
Type: ---
rdieter: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Tejas Dinkar 2008-06-13 19:05:02 UTC
Spec URL: http://tejas.fedorapeople.org/src/kopete-bonjour.spec
SRPM URL: http://tejas.fedorapeople.org/src/kopete-bonjour-1.0.0-1.fc9.src.rpm

This is the bonjour (iChat) protocol plugin for Kopete, which is KDE's instant messenger. The Code is hosted in KDE Extragear. I am the maintainer for the same.

The code is GPLv2 (or later)

As this is a plugin for kopete, there is very little user documentation or translation needed.

$ rpmlint kopete-bonjour-1.0.0-1.fc9.i386.rpm
kopete-bonjour.i386: W: no-documentation
kopete-bonjour.i386: W: no-version-in-last-changelog

Comment 1 Rex Dieter 2008-06-16 15:42:18 UTC
Can this be built against kdenetwork-4.1 or 4.0 or both?

Comment 2 Tejas Dinkar 2008-06-16 16:12:03 UTC
It builds with trunk so I'm sure that it'll be able to build with kdenetwork 
4.1 as well. It uses mostly Qt APIs, and extends a few kopete classes

Comment 3 Rakesh Pandit 2008-09-03 16:10:54 UTC
Are you interested in continuing this review ?

Comment 4 Rex Dieter 2008-09-04 14:53:40 UTC
Yes, but I won't have much free time this week.  If someone else wants to help out here, go for it.

Comment 6 Rex Dieter 2008-12-11 17:50:18 UTC
$ rpmlint *.rpm
kopete-bonjour.x86_64: W: no-documentation
kopete-bonjour.x86_64: W: no-version-in-last-changelog
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

1.  (cosmetic) drop needless %post/%postun scriptlets (no shlibs here), can do post review, before doing any official builds.

Looks clean, follows kde4 template, uses macros correctly.

I'll take your word for it wrt functionality (ie, it works), I can't test this myself right now.


Comment 7 Tejas Dinkar 2008-12-11 18:03:38 UTC
New Package CVS Request
Package Name: kopete-bonjour
Short Description: Bonjour Plugin For Kopete in KDE 4.0 and 4.1
Owners: rdieter tejas
Branches: F-9 F-10

Note: No devel branch needed, as this becomes a part of kopete in 4.2

Comment 8 Kevin Fenzi 2008-12-14 05:10:03 UTC
Sorry, a devel branch is always created. 
Please follow the http://fedoraproject.org/wiki/PackageMaintainers/PackageEndOfLife procedure for that branch. 

cvs done.

Note You need to log in before you can comment on or make changes to this bug.