Spec URL: http://tejas.fedorapeople.org/src/kopete-bonjour.spec SRPM URL: http://tejas.fedorapeople.org/src/kopete-bonjour-1.0.0-1.fc9.src.rpm Description: This is the bonjour (iChat) protocol plugin for Kopete, which is KDE's instant messenger. The Code is hosted in KDE Extragear. I am the maintainer for the same. The code is GPLv2 (or later) As this is a plugin for kopete, there is very little user documentation or translation needed. -- RPMLINT OUTPUT $ rpmlint kopete-bonjour-1.0.0-1.fc9.i386.rpm kopete-bonjour.i386: W: no-documentation kopete-bonjour.i386: W: no-version-in-last-changelog
Can this be built against kdenetwork-4.1 or 4.0 or both?
It builds with trunk so I'm sure that it'll be able to build with kdenetwork 4.1 as well. It uses mostly Qt APIs, and extends a few kopete classes
@Rex Are you interested in continuing this review ? Thanks,
Yes, but I won't have much free time this week. If someone else wants to help out here, go for it.
Hey, the new spec file and SRPM are here: http://tejas.fedorapeople.org/fedora-review/kopete-bonjour.spec http://tejas.fedorapeople.org/fedora-review/kopete-bonjour-1.0.3-3.fc10.src.rpm I've built this exact RPM using koji also: http://koji.fedoraproject.org/koji/taskinfo?taskID=993713 http://koji.fedoraproject.org/koji/taskinfo?taskID=993700
$ rpmlint *.rpm kopete-bonjour.x86_64: W: no-documentation kopete-bonjour.x86_64: W: no-version-in-last-changelog 1 packages and 0 specfiles checked; 0 errors, 2 warnings. 1. (cosmetic) drop needless %post/%postun scriptlets (no shlibs here), can do post review, before doing any official builds. Looks clean, follows kde4 template, uses macros correctly. I'll take your word for it wrt functionality (ie, it works), I can't test this myself right now. APPROVED.
New Package CVS Request ======================= Package Name: kopete-bonjour Short Description: Bonjour Plugin For Kopete in KDE 4.0 and 4.1 Owners: rdieter tejas Branches: F-9 F-10 InitialCC: Note: No devel branch needed, as this becomes a part of kopete in 4.2
Sorry, a devel branch is always created. Please follow the http://fedoraproject.org/wiki/PackageMaintainers/PackageEndOfLife procedure for that branch. cvs done.