SPEC: http://v3.sk/~lkundrak/SPECS/perl-String-Random.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-String-Random-0.22-1.el5.src.rpm Description: This module makes it trivial to generate random strings.
build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=667772 check for missing BuildRequires: perl(Test::More)
Hm, on my el5 perl(Test::More) is provided by core perl package. Thsi is most likely used only for testing, so I'll just disable the tests for newer Fedoras, I'll just have to find out which ones.
Oh -- now I get it, while looking at build logs. It is indeed that Test::More used to be provided by core perl package, but no longer is. Fixed package: SPEC: http://netbsd.sk/~lkundrak/SPECS/perl-String-Random.spec SRPM: http://netbsd.sk/~lkundrak/SRPMS/perl-String-Random-0.22-2.el5.src.rpm
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=676061 + rpmlint is silent for SRPM and for RPM. + source files match with different upstream url c0319f95c56450624cc646f7425e327e String-Random-0.22.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test All tests successful. Files=6, Tests=158, 0 wallclock secs ( 0.18 cusr + 0.03 csys = 0.21 CPU) + Package perl-String-Random-0.22-2.fc10 => Provides: perl(String::Random) = 0.22 Requires: perl >= 0:5.006_001 perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Exporter) perl(strict) perl(warnings) SHOULD=> Change Source URL to http://search.cpan.org/CPAN/authors/id/S/ST/STEVE/String-Random-0.22.tar.gz APPROVED.
New Package CVS Request ======================= Package Name: perl-String-Random Short Description: Perl module to generate random strings based on a pattern Owners: lkundrak Branches: F-8 F-9 EL-5 Cvsextras Commits: yes
cvs done.
Thanks Parag, thanks Kevin. Imported and built.