Red Hat Bugzilla – Bug 451727
Fd leak, uninitialized memory
Last modified: 2008-06-20 15:06:32 EDT
While trying to track down some crashes in kino, I found the following problems
* There is a DIR* leak in raw1394_set_port().
* Lots of data structures are not fully initialized when calling IEEE1394
ioctl()s. These cause valgrind errors (benign, as valgrind does not know how to
interpret all ioctls. However these also cause kino to crash in libraw1394.
I've added a bunch of memset()s to prevent this problem from happening.
Created attachment 309552 [details]
Patch fixing the problems.
Phil, thanks much for the patch, I'm going to submit it upstream with
attribution to you, unless you object. Will also get it patched into the Fedora
libraw1394 builds ASAP.
libraw1394-1.3.0-7.fc9 has been submitted as an update for Fedora 9
libraw1394-1.3.0-7.fc8 has been submitted as an update for Fedora 8
Meh. Patch is already public in the bz, I went ahead and sent it upstream on
your behalf, as Dan Dennedy already mentioned on the kino-dev list. Definitely
an improvement, thanks again!
libraw1394-1.3.0-7.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
libraw1394-1.3.0-7.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.