Bug 451727 - Fd leak, uninitialized memory
Summary: Fd leak, uninitialized memory
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: libraw1394
Version: 8
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Jarod Wilson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-16 23:57 UTC by Philippe Troin
Modified: 2008-06-20 19:06 UTC (History)
0 users

Fixed In Version: 1.3.0-7.fc9
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-20 19:04:27 UTC
Type: ---

Attachments (Terms of Use)
Patch fixing the problems. (3.00 KB, patch)
2008-06-16 23:57 UTC, Philippe Troin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Philippe Troin 2008-06-16 23:57:43 UTC 
While trying to track down some crashes in kino, I found the following problems
with libraw1394:

 * There is a DIR* leak in raw1394_set_port().
 * Lots of data structures are not fully initialized when calling IEEE1394
ioctl()s.  These cause valgrind errors (benign, as valgrind does not know how to
interpret all ioctls.  However these also cause kino to crash in libraw1394. 
I've added a bunch of memset()s to prevent this problem from happening.

Phil.
Comment 1 Philippe Troin 2008-06-16 23:57:43 UTC 
Created attachment 309552 [details]
Patch fixing the problems.
Comment 2 Jarod Wilson 2008-06-17 15:12:10 UTC 
Phil, thanks much for the patch, I'm going to submit it upstream with
attribution to you, unless you object. Will also get it patched into the Fedora
libraw1394 builds ASAP.
Comment 3 Fedora Update System 2008-06-17 15:54:50 UTC 
libraw1394-1.3.0-7.fc9 has been submitted as an update for Fedora 9
Comment 4 Fedora Update System 2008-06-17 15:55:41 UTC 
libraw1394-1.3.0-7.fc8 has been submitted as an update for Fedora 8
Comment 5 Jarod Wilson 2008-06-17 19:34:03 UTC 
Meh. Patch is already public in the bz, I went ahead and sent it upstream on
your behalf, as Dan Dennedy already mentioned on the kino-dev list. Definitely
an improvement, thanks again!
Comment 6 Fedora Update System 2008-06-20 19:04:25 UTC 
libraw1394-1.3.0-7.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 7 Fedora Update System 2008-06-20 19:06:32 UTC 
libraw1394-1.3.0-7.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.