Bug 451914 - use pango lang tags for language list
use pango lang tags for language list
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: gdm (Show other bugs)
rawhide
All Linux
low Severity low
: ---
: ---
Assigned To: jmccann
Fedora Extras Quality Assurance
:
Depends On:
Blocks: F10Target
  Show dependency treegraph
 
Reported: 2008-06-17 23:27 EDT by Jens Petersen
Modified: 2015-01-14 18:21 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-10 13:16:23 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
lang-tag.patch (1.51 KB, patch)
2008-07-08 23:28 EDT, Matthias Clasen
no flags Details | Diff
Nihongo.png (1.03 KB, image/png)
2008-07-09 20:25 EDT, Jens Petersen
no flags Details
better patch (1.63 KB, patch)
2008-07-10 01:11 EDT, Matthias Clasen
no flags Details | Diff

  None (edit)
Description Jens Petersen 2008-06-17 23:27:01 EDT
Description of problem:
gdm just using the default font rendering for languages in its language list.
This hits the font ordering issues with pango for Unihan (ie particularly for
Chinese and Japanese in this case): with current fedora font defaults Japanese
gets displayed with a Chinese glyphs in a non-ja locale.

How reproducible:
every time

Steps to Reproduce:
1. install rawhide
2. boot, firstboot and go to gdm lang list
3. look at rendering of ja and zh entries
  
Actual results:
3. Japanese (日本語) is rendered with Chinese font.

Expected results:
3. 日本語 should be in ja font

Additional info:
For F9 Live at least seems Japanese font was preferred somehow
but that is bad for Chinese users of course.
Comment 1 Matthias Clasen 2008-07-08 23:28:28 EDT
Created attachment 311339 [details]
lang-tag.patch

Here is an untested patch.
Comment 2 Jens Petersen 2008-07-09 19:58:50 EDT
Thanks for the patch.

I tested it and it doesn't quite seem to have an affect.  I think the problem is
that normalized_language has the full locale name "ja_JP.UTF-8" but pango
only understand the lang name "ja" in its tags if I understand correctly.
Comment 3 Jens Petersen 2008-07-09 20:25:56 EDT
Created attachment 311430 [details]
Nihongo.png

Japanese for Japanese in the Japanese font.
Comment 4 Matthias Clasen 2008-07-10 01:09:01 EDT
Oh, I was applying the tag to the tooltip...

Comment 5 Matthias Clasen 2008-07-10 01:11:28 EDT
Created attachment 311445 [details]
better patch
Comment 6 Jens Petersen 2008-07-10 02:40:30 EDT
Thanks, Matthias!

That works well - I also note that now the language order coincides with lang
code which is better.
Comment 7 Matthias Clasen 2008-07-10 09:11:11 EDT
Oh, thats an artifact of sorting on the markup, which now has the lang tag as
first differentiating part:

<span lang="foo>Foo...

Note You need to log in before you can comment on or make changes to this bug.