Red Hat Bugzilla – Bug 452105
Review Request: php-pear-Auth-RADIUS - Wrapper Classes for the RADIUS PECL
Last modified: 2008-06-24 22:52:32 EDT
Spec URL: http://xulchris.fedorapeople.org/packages/php-pear-Auth-RADIUS.spec
SRPM URL: http://xulchris.fedorapeople.org/packages/php-pear-Auth-RADIUS-1.0.6-1.fc9.src.rpm
Wrapper Classes for the RADIUS PECL.
Another trivial review; builds fine, rpmlint is silent and everything looks good
I assume you know that Requires(hint): is the same as Requires:, so this package
ends up depending on mcrypt, mhash, and Crypt-CHAP. They're tiny, so I don't
see this as a problem, but I don't really see the point in just not using
* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included (separately) upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
php-pear(Auth_RADIUS) = 1.0.6
php-pear-Auth-RADIUS = 1.0.6-1.fc10
php-pecl(radius) >= 1.2.5
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
I use requires(hint) as a note to myself (or someone looking at the spec) that
the package is optional. Kind of like a comment. Thanks for the review. :)
New Package CVS Request
Package Name: php-pear-Auth-RADIUS
Short Description: Wrapper Classes for the RADIUS PECL
Branches: EL-5 F-8 F-9
Cvsextras Commits: yes
I would suggest that if you wish to include a comment in the spec, you simply
use a regular comment instead of using syntax which simply isn't defined in Fedora.
php-pear-Auth-RADIUS-1.0.6-1.fc9 has been submitted as an update for Fedora 9
php-pear-Auth-RADIUS-1.0.6-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.